Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define osm_cluster_network_cidr and openshift_portal_net #616

Merged
merged 1 commit into from
Sep 8, 2017

Conversation

sdodson
Copy link
Contributor

@sdodson sdodson commented Sep 8, 2017

These are now required values in order to ensure that we don't change
defaults during upgrades

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 8, 2017
@sdodson
Copy link
Contributor Author

sdodson commented Sep 8, 2017

Unblocks openshift/openshift-ansible#5256

@sdodson sdodson requested review from jhadvig and ashcrow September 8, 2017 13:42
@ashcrow
Copy link
Contributor

ashcrow commented Sep 8, 2017

I've updated the blocked PR to also requireosm_host_subnet_length be set. Add:

osm_host_subnet_length=9

and we should be good.

osm_cluster_network_cidr, openshift_portal_net and
osm_host_subnet_length

These are now required values in order to ensure that we don't change
defaults during upgrades
Copy link
Contributor

@ashcrow ashcrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sdodson sdodson merged commit 4912f89 into openshift-eng:master Sep 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants