envoy: update image and go-control-plane version #4556
Conversation
shashankram
requested review from
snehachhabria,
nojnhuh,
draychev and
jaellio
as code owners
There was a problem hiding this comment.
LGTM, please also update the docs: https://github.com/openservicemesh/osm-docs/blob/97baa0d481928a5607c2dcb3dfb453e93cbf9acd/config.toml#L87
| sidecarImage: envoyproxy/envoy-alpine@sha256:6502a637c6c5fba4d03d0672d878d12da4bcc7a0d0fb3f1d506982dde0039abd | ||
| # -- Envoy sidecar image for Windows workloads (v1.19.1) | ||
| sidecarWindowsImage: envoyproxy/envoy-windows@sha256:c904fda95891ebbccb9b1f24c1a9482c8d01cbca215dd081fc8c8db36db85f85 | ||
| # -- Envoy sidecar image for Linux workloads (v1.21.1) |
There was a problem hiding this comment.
We might as well remove the version from these comments if it's included in the value itself.
There was a problem hiding this comment.
LGTM, please also update the docs: https://github.com/openservicemesh/osm-docs/blob/97baa0d481928a5607c2dcb3dfb453e93cbf9acd/config.toml#L87
Yes, I have a change that I will push to osm-docs once this merges.
Codecov Report
@@ Coverage Diff @@
## main #4556 +/- ##
==========================================
+ Coverage 69.20% 69.26% +0.05%
==========================================
Files 216 216
Lines 14660 14661 +1
==========================================
+ Hits 10146 10155 +9
+ Misses 4463 4455 -8
Partials 51 51
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
shashankram
added
wip
- Updates Envoy image to v1.21.1, which is the latest release with security patches applied - Updates go-control-plane module to v0.10.1. This is required to use latest changes to the XDS API, e.g. to set HTTP MaxRequestsPerConnection as a part of the HttpProtocolOptions. Resolves snapshot cache (experimental) compatibility with new SDK. - Removes Envoy cmd line argument for bootstrap version which is now the only supported version in Envoy. The cmd line flag has been removed in Envoy. Signed-off-by: Shashank Ram <[email protected]>
This change accounts for the change in envoy where custom metrics from WASM extensions are no longer prefixed with `envoy_`. The metrics as they exist in Prometheus are unchanged. Signed-off-by: Jon Huhn <[email protected]>
Signed-off-by: Shashank Ram <[email protected]>
shashankram
force-pushed
the
envoy-mod
branch
2 times, most recently
from
d6c48c0 to
0d688a5
Compare
Description:
Updates Envoy image to v1.21.1, which is the latest
release with security patches applied
Updates go-control-plane module to v0.10.1. This is
required to use latest changes to the XDS API, e.g.
to set HTTP MaxRequestsPerConnection as a part of the
HttpProtocolOptions.
Resolves snapshot cache (experimental) compatibility
with new SDK.
Removes Envoy cmd line argument for bootstrap version
which is now the only supported version in Envoy. The
cmd line flag has been removed in Envoy.
Accounts for the change in envoy where custom metrics from
WASM extensions are no longer prefixed with
envoy_. The metrics asthey exist in Prometheus are unchanged.
Update drain interval to 30s from 600s and set drain strategy to
immediate so that connections are drained sooner when the
listener is removed.
Testing done:
CI
Affected area:
Please answer the following questions with yes/no.
Does this change contain code from or inspired by another project?
noIs this a breaking change?
no