Skip to content
This repository has been archived by the owner on Jul 11, 2023. It is now read-only.

envoy: Update to Envoy version to 1.20.0 #4214

Closed
wants to merge 2 commits into from

Conversation

davinci26
Copy link

Updates Envoy version to 1.20 and validated
that there are no warnings with the existing config.

Should also fix #4141

Signed-off-by: Sotiris Nanopoulos [email protected]

Description:

Testing done:

Affected area:

Functional Area
New Functionality [ ]
CI System [ ]
CLI Tool [ ]
Certificate Management [ ]
Control Plane [ ]
Demo [ ]
Documentation [ ]
Egress [ ]
Ingress [ ]
Install [ ]
Networking [ ]
Observability [ ]
Performance [ ]
SMI Policy [ ]
Security [ ]
Sidecar Injection [ ]
Tests [ ]
Upgrade [ ]
Other [ ]

Please answer the following questions with yes/no.

  1. Does this change contain code from or inspired by another project?

    • Did you notify the maintainers and provide attribution?
  2. Is this a breaking change?

Updates Envoy version to 1.20 and validated
that there are no warnings with the existing config.

Should also fix openservicemesh#4141

Signed-off-by: Sotiris Nanopoulos <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Oct 5, 2021

Codecov Report

Merging #4214 (74aed63) into main (1caae97) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4214      +/-   ##
==========================================
- Coverage   70.11%   70.10%   -0.02%     
==========================================
  Files         214      214              
  Lines       11704    11703       -1     
==========================================
- Hits         8206     8204       -2     
- Misses       3446     3447       +1     
  Partials       52       52              
Flag Coverage Δ
unittests 70.10% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/injector/envoy_container.go 100.00% <ø> (ø)
pkg/certificate/rotor/rotor.go 84.37% <0.00%> (-3.13%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1caae97...74aed63. Read the comment docs.

Signed-off-by: Sotiris Nanopoulos <[email protected]>
@davinci26
Copy link
Author

I found some warnings through investigating the configs in e2e tests

@davinci26
Copy link
Author

blocked on envoyproxy/envoy#18616

@davinci26
Copy link
Author

@anrossi

@github-actions
Copy link

This PR will be closed due to a long period of inactivity. If you would like this PR to remain open then please comment or update.

@github-actions github-actions bot added the stale label Jan 30, 2022
@anrossi
Copy link

anrossi commented Jan 30, 2022

Don't close this issue yet. The work is ongoing.

@github-actions github-actions bot removed the stale label Jan 31, 2022
@anrossi
Copy link

anrossi commented Feb 3, 2022

@rectified95 FYI

@draychev
Copy link
Contributor

Thank you @anrossi and @rectified95 for working on this!

@github-actions
Copy link

This PR will be closed due to a long period of inactivity. If you would like this PR to remain open then please comment or update.

@github-actions github-actions bot added the stale label Apr 17, 2022
@github-actions
Copy link

PR closed due to inactivity.

@github-actions github-actions bot closed this Apr 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Windows nightly job is broken
4 participants