-
Notifications
You must be signed in to change notification settings - Fork 434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GET MAY return creds unable to be used #517
Merged
mattmcneeney
merged 15 commits into
openservicebrokerapi:master
from
MHBauer:get-no-creds
Jul 12, 2018
Merged
Changes from 10 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
e755cf2
GET may return creds unable to be used
MHBauer a859d31
all or nothing on credentials.
MHBauer 94beff6
proposed wording that addresses asynchronous bind
MHBauer d3f3d3d
add same text to binding create
MHBauer f296861
accidental word wrapping
MHBauer 0094af7
accidental deletion
MHBauer 3868de4
Merge branch 'master' into get-no-creds
MHBauer 430cea4
add to split response?
MHBauer 41513fd
oops.
MHBauer 5979f6e
move to new location
MHBauer 9f70b38
make sure we're in a GET response
MHBauer 67bdcd8
dug's suggested wording
MHBauer 2fb4952
remove old text
MHBauer c86b130
move to overall binding block
MHBauer 2ad9c34
hard 80 col wrap
MHBauer File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -1195,6 +1195,12 @@ utilize the Service Instance. Credentials SHOULD be unique whenever possible, so | |
access can be revoked for each binding without affecting consumers of other | ||
bindings for the Service Instance. | ||
|
||
This field MAY be omitted if the Service Broker either cannot return the credentials | ||
or does not want to for security reasons. During an asynchronous bind | ||
operation the Service Broker MUST include this field in at least the first response | ||
after the Service Binding has been successfully created, otherwise the Platform will | ||
not have the credentials to pass along. | ||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Dug suggested
|
||
#### Log Drain | ||
|
||
There are a class of Service Offerings that provide aggregation, indexing, and | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
first GET response (with link)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
link to what?