-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace 2x LogUtils
by QueryContext
#747
Replace 2x LogUtils
by QueryContext
#747
Conversation
…tils`. Signed-off-by: Yury Fridlyand <[email protected]>
Signed-off-by: Yury Fridlyand <[email protected]>
Signed-off-by: Yury Fridlyand <[email protected]>
Signed-off-by: Yury Fridlyand <[email protected]>
Signed-off-by: Yury Fridlyand <[email protected]>
Signed-off-by: Yury Fridlyand <[email protected]>
Signed-off-by: Yury Fridlyand <[email protected]>
Replace 2x `LogUtils` by `QueryContext`
Codecov Report
@@ Coverage Diff @@
## main #747 +/- ##
============================================
- Coverage 97.76% 94.79% -2.98%
Complexity 2880 2880
============================================
Files 276 286 +10
Lines 7077 7736 +659
Branches 447 565 +118
============================================
+ Hits 6919 7333 +414
- Misses 157 349 +192
- Partials 1 54 +53
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.x 1.x
# Navigate to the new working tree
cd .worktrees/backport-1.x
# Create a new branch
git switch --create backport/backport-747-to-1.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 deececbb03a9dcf9647bf8f2f651a4e3fe0a6c2e
# Push it to GitHub
git push --set-upstream origin backport/backport-747-to-1.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.x Then, create a pull request where the |
Signed-off-by: Yury Fridlyand <[email protected]> (cherry picked from commit deececb)
Signed-off-by: Yury Fridlyand <[email protected]> (cherry picked from commit deececb)
Signed-off-by: Yury Fridlyand <[email protected]> (cherry picked from commit deececb) Co-authored-by: Yury-Fridlyand <[email protected]>
Description
Remove duplicated classes.
QueryContext
class replaces twoLogUtils
classes. It will be also used in two upcoming features.Issues Resolved
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.