Add multi_match to SQL plugin #649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yury Fridlyand <[email protected]>
Signed-off-by: Yury Fridlyand <[email protected]>
…y_string` both. Signed-off-by: Yury Fridlyand <[email protected]>
Add implementation of `multi_match` similar to `simple_query_string`.
Codecov Report
@@ Coverage Diff @@
## main #649 +/- ##
=============================================
- Coverage 94.63% 62.76% -31.88%
=============================================
Files 279 10 -269
Lines 7517 658 -6859
Branches 556 119 -437
=============================================
- Hits 7114 413 -6701
+ Misses 349 192 -157
+ Partials 54 53 -1
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
dai-chen
reviewed
Jun 22, 2022
Comment on lines
146
to
151
| os> source=accounts | where multi_match(['firstname', city ^ 2], 'Amber Nogal', analyzer=keyword, operator='AND') | fields firstname, lastname, city, address; | ||
| fetched rows / total rows = 0/0 | ||
| +-------------+------------+--------+-----------+ | ||
| | firstname | lastname | city | address | | ||
| |-------------+------------+--------+-----------| | ||
| +-------------+------------+--------+-----------+ |
There was a problem hiding this comment.
maybe better to show an example query with non-empty response?
There was a problem hiding this comment.
Thank you. Please, see fix in d8cac8f.
Signed-off-by: Yury Fridlyand <[email protected]>
joshuali925
approved these changes
Jun 23, 2022
6 tasks
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add multi_match full-text search function to SQL and PPL.
Issues Resolved
#188
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.