-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the flaky test testExtractDatePartWithTimeType() #3225
Conversation
Signed-off-by: Lantao Jin <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 👍
Signed-off-by: Lantao Jin <[email protected]>
Signed-off-by: Lantao Jin <[email protected]>
Signed-off-by: Lantao Jin <[email protected]>
gentle ping @YANG-DB @dai-chen @penghuo @noCharger @ykmr1224 . Currently, CI failures in almost PRs relates to this issue. |
Seems there is an open issue #2477 and provided a temporary fix for similar another tests which are not including this one. |
* Fix the failure test testExtractDatePartWithTimeType() Signed-off-by: Lantao Jin <[email protected]> * skip test week with time type in Jan and Dec Signed-off-by: Lantao Jin <[email protected]> * add doc Signed-off-by: Lantao Jin <[email protected]> * fix incorrect format Signed-off-by: Lantao Jin <[email protected]> --------- Signed-off-by: Lantao Jin <[email protected]> (cherry picked from commit 0e4acd3) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* Fix the failure test testExtractDatePartWithTimeType() * skip test week with time type in Jan and Dec * add doc * fix incorrect format --------- (cherry picked from commit 0e4acd3) Signed-off-by: Lantao Jin <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@LantaoJin These tests appear to be failing again? (At least today). |
Description
Flaky test:
Caused by function extract(WEEK FROM ...) actually returns the number of the ISO 8601 week-of-week-based-year:
So the current expected number
53
in the test day 2024-12-30 is incorrect.The fixing is skipping the testing in December and January.
Related Issues
Resolves #3224
Check List
--signoff
.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.