Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove debug logging in ODBC driver #27

Merged
merged 1 commit into from
May 3, 2021

Conversation

dai-chen
Copy link
Collaborator

@dai-chen dai-chen commented May 1, 2021

Signed-off-by: Chen Dai [email protected]

Description

Remove debug logging due to security risk. Copy from the following ODFE PRs:

  1. Remove ODBC driver connection string logging opendistro-for-elasticsearch/sql#1099
  2. Remove unnecessary logging for SQL ODBC opendistro-for-elasticsearch/sql#1100

Issues Resolved

N/A

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@dai-chen dai-chen self-assigned this May 1, 2021
@dai-chen dai-chen marked this pull request as ready for review May 1, 2021 00:10
@dai-chen dai-chen changed the title Remove debug logging due to security issue Remove debug logging in ODBC driver May 1, 2021
@dai-chen dai-chen requested review from chloe-zh and penghuo May 1, 2021 00:10
@dai-chen dai-chen merged commit a7cc306 into opensearch-project:develop May 3, 2021
@dai-chen dai-chen deleted the odbc-security-fix branch May 3, 2021 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants