Add bcpkix-jdk15on runtimeOnly dependency to read keys with bouncycastle #2191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ith bouncycastle Signed-off-by: Craig Perkins <[email protected]>
cwperks
changed the title
|
This was definitely a |
DarshitChanpura
previously approved these changes
Oct 26, 2022
There was a problem hiding this comment.
This is awesome! Thank you for your effort @cwperks !!!
2 nits, but should not block this PR: 1. Remove sysout 2. remove commented code
cliu123
reviewed
Oct 26, 2022
cliu123
reviewed
Oct 26, 2022
cliu123
reviewed
Oct 26, 2022
cliu123
reviewed
Oct 26, 2022
Signed-off-by: Craig Perkins <[email protected]>
cwperks
dismissed stale reviews from DarshitChanpura and peternied
via
64c22a1
cliu123
approved these changes
Oct 26, 2022
Codecov Report
@@ Coverage Diff @@
## main #2191 +/- ##
============================================
- Coverage 61.14% 61.11% -0.04%
+ Complexity 3266 3263 -3
============================================
Files 259 259
Lines 18335 18334 -1
Branches 3248 3248
============================================
- Hits 11211 11204 -7
- Misses 5535 5538 +3
- Partials 1589 1592 +3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
peternied
approved these changes
Oct 26, 2022
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 26, 2022
…tle (#2191) * Add bouncycastle bcpkix-jdk15on runtimeOnly dependency to read keys with bouncycastle Signed-off-by: Craig Perkins <[email protected]> (cherry picked from commit 966b3fc)
peternied
pushed a commit
that referenced
this pull request
Oct 26, 2022
…tle (#2191) (#2200) * Add bouncycastle bcpkix-jdk15on runtimeOnly dependency to read keys with bouncycastle Signed-off-by: Craig Perkins <[email protected]> (cherry picked from commit 966b3fc) Co-authored-by: Craig Perkins <[email protected]>
3 tasks
stephen-crawford
pushed a commit
to stephen-crawford/security
that referenced
this pull request
Nov 10, 2022
…tle (opensearch-project#2191) * Add bouncycastle bcpkix-jdk15on runtimeOnly dependency to read keys with bouncycastle Signed-off-by: Craig Perkins <[email protected]> Signed-off-by: Stephen Crawford <[email protected]>
wuychn
pushed a commit
to ochprince/security
that referenced
this pull request
Mar 16, 2023
…tle (opensearch-project#2191) (opensearch-project#2200) * Add bouncycastle bcpkix-jdk15on runtimeOnly dependency to read keys with bouncycastle Signed-off-by: Craig Perkins <[email protected]> (cherry picked from commit 966b3fc) Co-authored-by: Craig Perkins <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Craig Perkins [email protected]
Description
Adds
bcpkix-jdk15onto runtime classpath to make netty use bouncycastle when reading key files. Netty has fallback logic to use existing PEMReader if bouncycastle fails to read the pemfile.Enhancement
Issues Resolved
Testing
Added unit test to test PKCS#1 format at unit test time.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.