Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate client transports to Apache HttpClient / Core 5.x #2172

Closed
wants to merge 1 commit into from

Conversation

reta
Copy link
Collaborator

@reta reta commented Oct 17, 2022

Signed-off-by: Andriy Redko [email protected]

Description

Migrate client transports to Apache HttpClient / Core 5.x

Issues Resolved

Closes #2171 and #2165

Testing

Existing tests do cover the change

Check List

  • New functionality includes testing
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@reta reta requested a review from a team October 17, 2022 20:21
@reta reta force-pushed the issue-2171 branch 2 times, most recently from be097b3 to d42a66c Compare October 17, 2022 21:05
@codecov-commenter
Copy link

Codecov Report

Merging #2172 (d42a66c) into main (16b1676) will increase coverage by 0.05%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main    #2172      +/-   ##
============================================
+ Coverage     61.12%   61.18%   +0.05%     
- Complexity     3236     3237       +1     
============================================
  Files           258      258              
  Lines         18110    18125      +15     
  Branches       3224     3224              
============================================
+ Hits          11070    11089      +19     
+ Misses         5461     5459       -2     
+ Partials       1579     1577       -2     
Impacted Files Coverage Δ
...org/opensearch/security/httpclient/HttpClient.java 87.09% <100.00%> (+1.21%) ⬆️
...a/org/opensearch/security/tools/SecurityAdmin.java 36.37% <100.00%> (+0.61%) ⬆️
...ecurity/ssl/rest/SecuritySSLReloadCertsAction.java 84.78% <0.00%> (-0.33%) ⬇️
...opensearch/security/ssl/util/SSLRequestHelper.java 65.71% <0.00%> (+1.90%) ⬆️
...ttp/netty/SecuritySSLNettyHttpServerTransport.java 84.21% <0.00%> (+5.26%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@peternied peternied left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking this on, it looks like @cwperks might have fixed some of the issues that are impacting the tests, maybe take a quick look at #2166

As soon as CI is passing I'll be signing off, thanks for dedicating time to this

@reta
Copy link
Collaborator Author

reta commented Oct 18, 2022

Closing in favor of #2166

@reta reta closed this Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Migrate client transports to Apache HttpClient / Core 5.x
3 participants