[2.x] Explicitly pass basePath: false in jwt_auth.test.ts
#1552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
Codecov Report
@@ Coverage Diff @@
## 2.x #1552 +/- ##
=======================================
Coverage 66.06% 66.06%
=======================================
Files 93 93
Lines 2328 2328
Branches 310 310
=======================================
Hits 1538 1538
Misses 722 722
Partials 68 68 |
|
Why manually backport? |
|
@peternied testing out the CI on 2.x currently. The integration tests fail on 2.x, but succeed on main and there are very few changes between the branches (https://github.com/opensearch-project/security-dashboards-plugin/compare/2.x..main). The CI is not running on github outside of creating a PR. |
You can enable GitHub Actions on your fork |
|
Closing this for now. I am testing with act to try to replicate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR explicitly sets
basePathto false in jwt_auth.test.ts to ensure that the test does not run with a basePathFixes CI errors seen in: #1550
I'm am looking more into
osdTestServer.getRootWithSettingsto see why the default is not being picked up: https://github.com/opensearch-project/OpenSearch-Dashboards/blob/9253a372004ae108afad01cdc41d36a9ceccd1ff/src/core/test_helpers/osd_server.ts#L75-L104Category
[Enhancement, New feature, Bug fix, Test fix, Refactoring, Maintenance, Documentation]
Test fix
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.