Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "Get started" image is not adaptive to the browser window size. #1396

Merged
merged 4 commits into from
Apr 12, 2023
Merged

Fix "Get started" image is not adaptive to the browser window size. #1396

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
da9ca0a
Fixed get-started page image not adapting to the browser window size
curq Apr 6, 2023
e480ad3
Update fix by applying suggested changes
curq Apr 6, 2023
305843e
Update unit tests snapshot
curq Apr 6, 2023
acc7202
Merge branch 'main' into getStarted-image-fix
stephen-crawford Apr 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions public/apps/configuration/panels/get-started.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,13 +184,15 @@ export function GetStarted(props: AppDependencies) {

<EuiSpacer size="l" />
{props.config.ui.backend_configurable && (
<div className="text-center">
<EuiImage
size="xl"
alt="Three steps to set up your security"
url={securityStepsDiagram}
/>
</div>
<EuiFlexGroup justifyContent="center">
<EuiFlexItem style={{ maxWidth: '600px' }}>
<EuiImage
size="fullWidth"
alt="Three steps to set up your security"
url={securityStepsDiagram}
/>
</EuiFlexItem>
</EuiFlexGroup>
)}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<EuiSpacer size="l" />
{props.config.ui.backend_configurable && (
<div className="text-center">
<EuiImage
size="xl"
alt="Three steps to set up your security"
url={securityStepsDiagram}
/>
</div>
<EuiFlexGroup justifyContent="center">
<EuiFlexItem style={{ maxWidth: '600px' }}>
<EuiImage
size="fullWidth"
alt="Three steps to set up your security"
url={securityStepsDiagram}
/>
</EuiFlexItem>
</EuiFlexGroup>
)}
<EuiSpacer size="l" />
{props.config.ui.backend_configurable && (
<div className="text-center">
<EuiImage
size="xl"
alt="Three steps to set up your security"
url={securityStepsDiagram}
style={{ maxWidth: '100%', height: 'auto', width: 'auto' }}
/>
</div>
)}


<EuiSpacer size="l" />
Expand Down