Refactored flaky test. #1464
Merged
Refactored flaky test. #1464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: AWSHurneyt <[email protected]>
AWSHurneyt
requested review from
amsiglan,
getsaurabh02,
lezzago,
praveensameneni,
sbcd90,
eirsep,
jowg-amazon,
engechas,
goyamegh and
riysaxen-amzn
as code owners
Signed-off-by: AWSHurneyt <[email protected]>
eirsep
reviewed
Feb 1, 2025
|
|
||
| // TODO: The test is cleaning up the detectors delegate monitors prematurely, causing this test to be flaky. | ||
| // Adjusting test case to >= 1 to reduce flakiness pending further investigation. | ||
| Integer newTotalAlerts = (Integer) getAlertsBody.getOrDefault("total_alerts", null); |
There was a problem hiding this comment.
Not sure if it is cleaning monitor prematurely or if the update detector is deleting a monitor
eirsep
approved these changes
Feb 1, 2025
Signed-off-by: AWSHurneyt <[email protected]>
sbcd90
approved these changes
Feb 3, 2025
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Feb 3, 2025
* Refactored flaky test. Signed-off-by: AWSHurneyt <[email protected]> * Refactored test for flakiness. Signed-off-by: AWSHurneyt <[email protected]> * Updated tests. Signed-off-by: AWSHurneyt <[email protected]> --------- Signed-off-by: AWSHurneyt <[email protected]> (cherry picked from commit 783167a)
AWSHurneyt
added a commit
to AWSHurneyt/security-analytics
that referenced
this pull request
Feb 3, 2025
* Refactored flaky test. Signed-off-by: AWSHurneyt <[email protected]> * Refactored test for flakiness. Signed-off-by: AWSHurneyt <[email protected]> * Updated tests. Signed-off-by: AWSHurneyt <[email protected]> --------- Signed-off-by: AWSHurneyt <[email protected]> (cherry picked from commit 783167a)
AWSHurneyt
added a commit
that referenced
this pull request
Feb 3, 2025
* Refactored flaky test. Signed-off-by: AWSHurneyt <[email protected]> * Refactored test for flakiness. Signed-off-by: AWSHurneyt <[email protected]> * Updated tests. Signed-off-by: AWSHurneyt <[email protected]> --------- Signed-off-by: AWSHurneyt <[email protected]> (cherry picked from commit 783167a) Co-authored-by: AWSHurneyt <[email protected]>
AWSHurneyt
added a commit
that referenced
this pull request
Feb 6, 2025
* Refactored flaky test. (#1464) * Refactored flaky test. Signed-off-by: AWSHurneyt <[email protected]> * Refactored test for flakiness. Signed-off-by: AWSHurneyt <[email protected]> * Updated tests. Signed-off-by: AWSHurneyt <[email protected]> --------- Signed-off-by: AWSHurneyt <[email protected]> (cherry picked from commit 783167a) * fix version dependency issues Signed-off-by: Subhobrata Dey <[email protected]> --------- Signed-off-by: Subhobrata Dey <[email protected]> Co-authored-by: Subhobrata Dey <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Manual backport of PR #1467
https://ci.opensearch.org/ci/dbc/integ-test/2.19.0/10772/linux/x64/tar/test-results/9318/integ-test/security-analytics/with-security/opensearch-integ-test/classes/org.opensearch.securityanalytics.alerts.AlertsIT.html#testMultipleAggregationAndDocRules_alertSuccess
Related Issues
#1451
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.