Whitesource remediate/gradle 8.x #517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: mend-for-github-com[bot] <mend-for-github-com[bot]@users.noreply.github.com>
reta
requested review from
joshpalis,
owaiskazi19,
ryanbogan,
saratvemulapalli and
dbwiddis
as code owners
saratvemulapalli
previously approved these changes
Mar 3, 2023
reta
force-pushed
the
whitesource-remediate/gradle-8.x
branch
from
18df138 to
22e0c1e
Compare
owaiskazi19
previously approved these changes
Mar 3, 2023
dbwiddis
previously approved these changes
Mar 3, 2023
|
Build fails with Looking into it ... |
|
Changes "look" good but not sure why the tests are failing so holding off on merging. |
|
For the record, 8.0.2 didn't fully fix the issue, so we are still waiting for 8.1 on this workaround. @reta of note we use Junit 5. |
Signed-off-by: Andriy Redko <[email protected]>
reta
force-pushed
the
whitesource-remediate/gradle-8.x
branch
from
22e0c1e to
30d7bb9
Compare
reta
commented
Mar 3, 2023
|
@dbwiddis should be all set, thanks! |
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #517 +/- ##
=========================================
Coverage 66.98% 66.98%
Complexity 188 188
=========================================
Files 35 35
Lines 833 833
Branches 25 25
=========================================
Hits 558 558
Misses 264 264
Partials 11 11 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
owaiskazi19
approved these changes
Mar 3, 2023
dbwiddis
approved these changes
Mar 5, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 5, 2023
* Update dependency gradle to v8 Signed-off-by: mend-for-github-com[bot] <mend-for-github-com[bot]@users.noreply.github.com> * Applied temporary workaround for gradle/gradle#23995 Signed-off-by: Andriy Redko <[email protected]> --------- Signed-off-by: mend-for-github-com[bot] <mend-for-github-com[bot]@users.noreply.github.com> Signed-off-by: Andriy Redko <[email protected]> Co-authored-by: mend-for-github-com[bot] <50673670+mend-for-github-com[bot]@users.noreply.github.com> (cherry picked from commit 9df742a) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dbwiddis
pushed a commit
that referenced
this pull request
Mar 5, 2023
* Update dependency gradle to v8 * Applied temporary workaround for gradle/gradle#23995 --------- (cherry picked from commit 9df742a) Signed-off-by: mend-for-github-com[bot] <mend-for-github-com[bot]@users.noreply.github.com> Signed-off-by: Andriy Redko <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: mend-for-github-com[bot] <50673670+mend-for-github-com[bot]@users.noreply.github.com>
kokibas
pushed a commit
to kokibas/opensearch-sdk-java
that referenced
this pull request
Mar 17, 2023
* Update dependency gradle to v8 Signed-off-by: mend-for-github-com[bot] <mend-for-github-com[bot]@users.noreply.github.com> * Applied temporary workaround for gradle/gradle#23995 Signed-off-by: Andriy Redko <[email protected]> --------- Signed-off-by: mend-for-github-com[bot] <mend-for-github-com[bot]@users.noreply.github.com> Signed-off-by: Andriy Redko <[email protected]> Co-authored-by: mend-for-github-com[bot] <50673670+mend-for-github-com[bot]@users.noreply.github.com>
kokibas
pushed a commit
to kokibas/opensearch-sdk-java
that referenced
this pull request
Mar 19, 2023
* Update dependency gradle to v8 Signed-off-by: mend-for-github-com[bot] <mend-for-github-com[bot]@users.noreply.github.com> * Applied temporary workaround for gradle/gradle#23995 Signed-off-by: Andriy Redko <[email protected]> --------- Signed-off-by: mend-for-github-com[bot] <mend-for-github-com[bot]@users.noreply.github.com> Signed-off-by: Andriy Redko <[email protected]> Co-authored-by: mend-for-github-com[bot] <50673670+mend-for-github-com[bot]@users.noreply.github.com> Signed-off-by: Nurym <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reopening #441 with JUnit Framework workaround
Issues Resolved
See please #441
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.