Move settings update consumers to new SDKClusterSettings class #389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbwiddis
requested review from
CEHENKLE,
joshpalis,
owaiskazi19,
ryanbogan and
saratvemulapalli
as code owners
joshpalis
previously approved these changes
Jan 30, 2023
Signed-off-by: Daniel Widdis <[email protected]>
dbwiddis
force-pushed
the
sdk-cluster-settings
branch
from
a889740 to
861e855
Compare
joshpalis
approved these changes
Jan 30, 2023
saratvemulapalli
approved these changes
Jan 31, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Feb 3, 2023
Signed-off-by: Daniel Widdis <[email protected]> (cherry picked from commit 8cc8176) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ryanbogan
pushed a commit
that referenced
this pull request
Feb 3, 2023
…#412) (cherry picked from commit 8cc8176) Signed-off-by: Daniel Widdis <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kokibas
pushed a commit
to kokibas/opensearch-sdk-java
that referenced
this pull request
Mar 17, 2023
…earch-project#389) Signed-off-by: Daniel Widdis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Daniel Widdis [email protected]
Description
Moves the settings update consumer calls to a
SDKClusterSettingsclass to better match current extension existing code and tests.Issues Resolved
Part of #353
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.