Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Plugin to Extension migration guide #372

Merged
merged 2 commits into from
Feb 2, 2023

Conversation

dbwiddis
Copy link
Member

Signed-off-by: Daniel Widdis [email protected]

Description

Documents the current changes needed for migration of Anomaly Detector plugin to extension

Issues Resolved

Part of #353

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@codecov-commenter
Copy link

codecov-commenter commented Jan 28, 2023

Codecov Report

Merging #372 (bd6abd2) into main (9882630) will decrease coverage by 9.53%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff              @@
##               main     #372      +/-   ##
============================================
- Coverage     69.35%   59.82%   -9.53%     
- Complexity      126      127       +1     
============================================
  Files            27       29       +2     
  Lines           558      697     +139     
  Branches         15       15              
============================================
+ Hits            387      417      +30     
- Misses          162      272     +110     
+ Partials          9        8       -1     
Impacted Files Coverage Δ
src/main/java/org/opensearch/sdk/Extension.java 60.00% <0.00%> (-15.00%) ⬇️
...ain/java/org/opensearch/sdk/SDKClusterService.java 100.00% <0.00%> (ø)
.../main/java/org/opensearch/sdk/EngineExtension.java 0.00% <0.00%> (ø)
.../main/java/org/opensearch/sdk/SearchExtension.java 0.00% <0.00%> (ø)
src/main/java/org/opensearch/sdk/SDKClient.java 89.39% <0.00%> (+9.39%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@dbwiddis dbwiddis marked this pull request as ready for review February 1, 2023 23:28
Copy link
Member

@ryanbogan ryanbogan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few minor suggestions, but otherwise LGTM!

Signed-off-by: Daniel Widdis <[email protected]>
Copy link
Collaborator

@minalsha minalsha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dbwiddis dbwiddis merged commit 603c878 into opensearch-project:main Feb 2, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Feb 3, 2023
(cherry picked from commit 603c878)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ryanbogan pushed a commit that referenced this pull request Feb 3, 2023
(cherry picked from commit 603c878)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@dbwiddis dbwiddis deleted the migration branch February 19, 2023 22:43
kokibas pushed a commit to kokibas/opensearch-sdk-java that referenced this pull request Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants