Provide a higher level implementation for REST handlers

[dbwiddis]

Signed-off-by: Daniel Widdis [email protected]

Description

Creates a RouteHandler class extending Route which also includes a handler method

Creates a BaseExtensionRestHandler abstract class:

• Matches the request's route to its handler
• Moves the unhandled request boilerplate into the superclass

Note to reviewers: consider this comment for two possible implementations. Happy to switch back to the other one if you don't like the one I chose. The actual implementation permits either choice; the question is more about what we want the HelloWorld sample to show.

Issues Resolved

Fixes #128
Fixes #245

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[codecov-commenter]

Codecov Report

Merging #246 (ee5a298) into main (6df1fa4) will increase coverage by 1.60%.
The diff coverage is 88.37%.

@@             Coverage Diff              @@
##               main     #246      +/-   ##
============================================
+ Coverage     67.19%   68.79%   +1.60%     
- Complexity      102      114      +12     
============================================
  Files            24       27       +3     
  Lines           506      532      +26     
  Branches         17       17              
============================================
+ Hits            340      366      +26     
- Misses          154      155       +1     
+ Partials         12       11       -1     

Impacted Files	Coverage Δ
.../java/org/opensearch/sdk/ExtensionRestHandler.java	0.00% <0.00%> (ø)
...a/org/opensearch/sdk/BaseExtensionRestHandler.java	89.47% <89.47%> (ø)
...ch/sdk/sample/helloworld/rest/RestHelloAction.java	85.10% <89.47%> (+7.32%)	⬆️
src/main/java/org/opensearch/sdk/RouteHandler.java	100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[dbwiddis]

@mloufra FYI this can simplify your handlers in #213 and #221 if merged before they are.

A better example of the changes you might need is in https://github.com/opensearch-project/anomaly-detection/pull/726/files

However, it's a bit out of scope of what you're doing, so it's totally optional if you think it's too confusing.

[mloufra]

@mloufra FYI this can simplify your handlers in #213 and #221 if merged before they are.

A better example of the changes you might need is in https://github.com/opensearch-project/anomaly-detection/pull/726/files

However, it's a bit out of scope of what you're doing, so it's totally optional if you think it's too confusing.

Thanks @dbwiddis for these information, I will take a look on that.

[mloufra]

@mloufra FYI this can simplify your handlers in #213 and #221 if merged before they are.
A better example of the changes you might need is in https://github.com/opensearch-project/anomaly-detection/pull/726/files
However, it's a bit out of scope of what you're doing, so it's totally optional if you think it's too confusing.

I will push the code change after this PR merged

[dbwiddis]

I will push the code change after this PR merged

@mloufra this one may take a while, don't hold up your PR

[mloufra]

I will push the code change after this PR merged

@mloufra this one may take a while, don't hold up your PR

got it