Removed setters to avoid accessing extension attributes

Signed-off-by: Owais Kazi <[email protected]>
opensearch-project · Jul 13, 2022 · a9a72fb · a9a72fb
1 parent 94f720e
commit a9a72fb
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 16 deletions.
diff --git a/src/main/java/org/opensearch/sdk/ExtensionSettings.java b/src/main/java/org/opensearch/sdk/ExtensionSettings.java
@@ -22,30 +22,26 @@ public class ExtensionSettings {
     // Change the location to extension.yml file of the extension
     public static final String EXTENSION_DESCRIPTOR = "src/test/resources/extension.yml";
 
-    public String getExtensionname() {
-        return extensionname;
+    public ExtensionSettings(String extensionname, String hostaddress, String hostport) {
+        this.extensionname = extensionname;
+        this.hostaddress = hostaddress;
+        this.hostport = hostport;
     }
 
-    public void setExtensionname(String extensionname) {
-        this.extensionname = extensionname;
+    public ExtensionSettings() {}
+
+    public String getExtensionname() {
+        return extensionname;
     }
 
     public String getHostaddress() {
         return hostaddress;
     }
 
-    public void setHostaddress(String hostaddress) {
-        this.hostaddress = hostaddress;
-    }
-
     public String getHostport() {
         return hostport;
     }
 
-    public void setHostport(String hostport) {
-        this.hostport = hostport;
-    }
-
     @Override
     public String toString() {
         return "\nnodename: " + extensionname + "\nhostaddress: " + hostaddress + "\nhostPort: " + hostport + "\n";

diff --git a/src/test/java/org/opensearch/sdk/TestExtensionSettings.java b/src/test/java/org/opensearch/sdk/TestExtensionSettings.java
@@ -10,24 +10,21 @@ public class TestExtensionSettings extends OpenSearchTestCase {
 
     @BeforeEach
     public void setUp() {
-        extensionSettings = new ExtensionSettings();
+        extensionSettings = new ExtensionSettings("test-extension", "127.0.0.1", "1234");
     }
 
     @Test
     public void testExtensionName() {
-        extensionSettings.setExtensionname("test-extension");
         assertEquals(extensionSettings.getExtensionname(), "test-extension");
     }
 
     @Test
     public void testHostAddress() {
-        extensionSettings.setHostaddress("127.0.0.1");
         assertEquals(extensionSettings.getHostaddress(), "127.0.0.1");
     }
 
     @Test
     public void testHostPort() {
-        extensionSettings.setHostport("1234");
         assertEquals(extensionSettings.getHostport(), "1234");
     }
 }