-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor release issue creation workflows #5344
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5344 +/- ##
=======================================
Coverage 92.04% 92.04%
=======================================
Files 202 202
Lines 7043 7043
=======================================
Hits 6483 6483
Misses 560 560 ☔ View full report in Codecov by Sentry. |
…from version manifests Signed-off-by: Sayali Gaikawad <[email protected]>
8a9e39f
to
2486892
Compare
Signed-off-by: Sayali Gaikawad <[email protected]>
Signed-off-by: Sayali Gaikawad <[email protected]>
Signed-off-by: Sayali Gaikawad <[email protected]>
peterzhuamazon
approved these changes
Feb 25, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @gaiksaya !
Signed-off-by: Sayali Gaikawad <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change refactors release issue creation workflows to dynamically retrieve components. There was a miss in recent releases that new plugins did not receive release issues. See https://github.com/opensearch-project/opensearch-learning-to-rank-base/issues?q=is%3Aissue%20state%3Aopen%202.19.0
In order to avoid maintaining duplicate lists everywhere, example this workflow will parse the manifest files and accordingly grab all repo URLs for a given version and create issues moving forward.
Also duplicate code for issue generation now resides in create-release-issues.yml.
Issues Resolved
part of #5332
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.