Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typechecking for assemble_workflow #1230

Merged
merged 2 commits into from
Dec 2, 2021

Conversation

peternied
Copy link
Member

Signed-off-by: Peter Nied [email protected]

Description

Adding typechecking onto all files under src/assemble_workflow

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@peternied peternied requested a review from dblock December 2, 2021 17:53
@peternied peternied requested a review from a team as a code owner December 2, 2021 17:53
@codecov-commenter
Copy link

codecov-commenter commented Dec 2, 2021

Codecov Report

Merging #1230 (7b8c864) into main (5820881) will decrease coverage by 0.14%.
The diff coverage is 98.86%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1230      +/-   ##
============================================
- Coverage     93.22%   93.07%   -0.15%     
  Complexity       11       11              
============================================
  Files           113      113              
  Lines          2729     2758      +29     
  Branches         10       10              
============================================
+ Hits           2544     2567      +23     
- Misses          175      181       +6     
  Partials         10       10              
Impacted Files Coverage Δ
src/assemble_workflow/dist.py 94.64% <92.30%> (-1.44%) ⬇️
src/assemble_workflow/assemble_args.py 100.00% <100.00%> (ø)
src/assemble_workflow/bundle.py 94.52% <100.00%> (+0.31%) ⬆️
src/assemble_workflow/bundle_opensearch.py 100.00% <100.00%> (ø)
.../assemble_workflow/bundle_opensearch_dashboards.py 100.00% <100.00%> (ø)
src/assemble_workflow/bundle_recorder.py 100.00% <100.00%> (ø)
src/assemble_workflow/bundles.py 100.00% <100.00%> (ø)
src/manifests/build_manifest.py 100.00% <100.00%> (ø)
src/paths/assemble_output_dir.py 100.00% <100.00%> (ø)
src/paths/output_dir.py 100.00% <100.00%> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5820881...7b8c864. Read the comment docs.

Copy link
Member

@owaiskazi19 owaiskazi19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@peternied peternied merged commit e45558e into opensearch-project:main Dec 2, 2021
@peternied peternied deleted the typecheck-assemble branch December 2, 2021 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants