Add library to check, request and assign component release owners #590
Conversation
gaiksaya
requested review from
peterzhuamazon,
prudhvigodithi,
rishabh6788,
Divyaasm and
zelinh
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #590 +/- ##
============================================
- Coverage 83.62% 83.52% -0.11%
- Complexity 142 150 +8
============================================
Files 124 126 +2
Lines 843 886 +43
Branches 100 106 +6
============================================
+ Hits 705 740 +35
- Misses 41 44 +3
- Partials 97 102 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| if (releaseOwner == null || releaseOwner.isEmpty()) { | ||
| componentsMissingReleaseOwners.add(component.name) | ||
| if (action != 'check') { | ||
| handleMissingReleaseOwner(component, releaseMetricsData, componentRepoData, action) |
There was a problem hiding this comment.
notifyMissingReleaseOwner?
There was a problem hiding this comment.
It handles both request and assign actions. Hence used the generic name
|
|
||
| List<String> maintainersWithTag = componentMaintainers.collect { "@$it" } | ||
|
|
||
| switch (action) { |
There was a problem hiding this comment.
what is the logic to handle different actions?
There was a problem hiding this comment.
Its mentioned below. Depending on the request or assign. For requesting it will just comment tagging all the maintainers to volunteer one. If assign it will randomly assign one.
|
|
||
| String action = args.action | ||
| println("Action is: ${action}") | ||
| List<String> validActions = ['check', 'assign', 'request'] |
There was a problem hiding this comment.
Where are we implementing check action here Sayali?
Is it check and assign or check and request based on release time line?
There was a problem hiding this comment.
Just will just output the the components missing the release owners on the console. What we want to do with it, we can iterate later.
Signed-off-by: Sayali Gaikawad <[email protected]>
Signed-off-by: Sayali Gaikawad <[email protected]>
Signed-off-by: Sayali Gaikawad <[email protected]>
Signed-off-by: Sayali Gaikawad <[email protected]>
Signed-off-by: Sayali Gaikawad <[email protected]> (cherry picked from commit dbf78ad) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Description
This change adds a library to check, request release owners for missing ones and assigns one as well.
Issues Resolved
opensearch-project/opensearch-build#5332
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.