fix actions components after core #9082 #739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: zhichao-aws <[email protected]>
zhichao-aws
requested review from
xluo-aws,
gaobinlong,
Hailong-am,
SuZhou-Joe,
yuye-aws and
zhongnansu
as code owners
gaobinlong
previously approved these changes
Aug 16, 2023
|
the build failed due to compile issue for test files |
Signed-off-by: zhichao-aws <[email protected]>
|
@Hailong-am Fix the compile error in test code. Current build failure is in bwc test, the 2.10 node can not start now because the core refactor has been backported to 2.x . We need to backport our fix to make it work. |
Hailong-am
approved these changes
Aug 16, 2023
gaobinlong
approved these changes
Aug 16, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 16, 2023
* fix actions Signed-off-by: zhichao-aws <[email protected]> * fix test Signed-off-by: zhichao-aws <[email protected]> --------- Signed-off-by: zhichao-aws <[email protected]> (cherry picked from commit d36b9c0) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
zhichao-aws
pushed a commit
that referenced
this pull request
Aug 18, 2023
* fix actions * fix test --------- (cherry picked from commit d36b9c0) Signed-off-by: zhichao-aws <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix actions components after core #9082
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.