-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix jarhell of common-utils #328
Conversation
Signed-off-by: Zhongnan Su <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #328 +/- ##
=========================================
Coverage 92.16% 92.16%
Complexity 360 360
=========================================
Files 51 51
Lines 1111 1111
Branches 51 51
=========================================
Hits 1024 1024
Misses 69 69
Partials 18 18
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for fixing this.
@zhongnansu feel free to backport to 1.x, 2.x branch if needed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Zhongnan Su <[email protected]>
Signed-off-by: Zhongnan Su <[email protected]>
Signed-off-by: Zhongnan Su [email protected]
Description
While adding common-utils to sql project for transport interface feature[https://github.com/opensearch-project/sql/pull/533], there's a jarhell issue caused by common-utils being packaged into ml-commos jar. Need to change it from
implementation
tocompileOnly
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.