Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix jarhell of common-utils #328

Merged
merged 1 commit into from
May 24, 2022

Conversation

zhongnansu
Copy link
Member

@zhongnansu zhongnansu commented May 20, 2022

Signed-off-by: Zhongnan Su [email protected]

Description

While adding common-utils to sql project for transport interface feature[https://github.com/opensearch-project/sql/pull/533], there's a jarhell issue caused by common-utils being packaged into ml-commos jar. Need to change it from implementation to compileOnly

| Caused by: java.lang.IllegalStateException: jar hell!
| class: org.opensearch.commons.ConfigConstants
| jar1: /Users/szhongna/Desktop/Projects/OpenSearch/sql/doctest/build/testclusters/docTestCluster-0/distro/2.0.0-INTEG_TEST/plugins/.installing-4482172287902453920/common-utils-2.0.0.0-SNAPSHOT.jar
| jar2: /Users/szhongna/Desktop/Projects/OpenSearch/sql/doctest/build/testclusters/docTestCluster-0/distro/2.0.0-INTEG_TEST/plugins/.installing-4482172287902453920/opensearch-ml-client-2.0.0.0-SNAPSHOT.jar

image

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Zhongnan Su <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented May 20, 2022

Codecov Report

Merging #328 (0d95d99) into main (42fd67e) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main     #328   +/-   ##
=========================================
  Coverage     92.16%   92.16%           
  Complexity      360      360           
=========================================
  Files            51       51           
  Lines          1111     1111           
  Branches         51       51           
=========================================
  Hits           1024     1024           
  Misses           69       69           
  Partials         18       18           
Flag Coverage Δ
ml-commons 92.16% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42fd67e...0d95d99. Read the comment docs.

Copy link
Collaborator

@ylwu-amzn ylwu-amzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for fixing this.

@zhongnansu zhongnansu marked this pull request as ready for review May 24, 2022 00:57
@zhongnansu zhongnansu requested a review from a team May 24, 2022 00:57
@zhongnansu
Copy link
Member Author

@anirudha @penghuo Need 1 more reviewer.

@zhongnansu zhongnansu changed the title fix jarhell of common-utils Fix jarhell of common-utils May 24, 2022
@Zhangxunmt Zhangxunmt merged commit 836ea26 into opensearch-project:main May 24, 2022
@ylwu-amzn
Copy link
Collaborator

@zhongnansu feel free to backport to 1.x, 2.x branch if needed.

Copy link

@penghuo penghuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

zane-neo pushed a commit to zane-neo/ml-commons that referenced this pull request Dec 29, 2022
zane-neo pushed a commit to zane-neo/ml-commons that referenced this pull request Dec 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants