Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply spotless on entire project #336

Merged
merged 2 commits into from
Mar 29, 2022

Conversation

jmazanec15
Copy link
Member

Signed-off-by: John Mazanec [email protected]

Description

Removed the ratchetFrom line in the gradle/formatting.gradle file and then ran

./gradlew spotlessApply

After this PR is merged, spotless will only fix issues in the code written in the PRs.

Issues Resolved

#332

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed as per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@jmazanec15 jmazanec15 added the Refactoring Improve the design, structure, and implementation while preserving its functionality label Mar 28, 2022
@jmazanec15 jmazanec15 requested a review from a team March 28, 2022 22:04
@codecov-commenter
Copy link

codecov-commenter commented Mar 28, 2022

Codecov Report

Merging #336 (1534b24) into main (9c0b1d0) will increase coverage by 0.17%.
The diff coverage is 81.75%.

@@             Coverage Diff              @@
##               main     #336      +/-   ##
============================================
+ Coverage     83.81%   83.99%   +0.17%     
  Complexity      900      900              
============================================
  Files           130      130              
  Lines          3844     3854      +10     
  Branches        360      353       -7     
============================================
+ Hits           3222     3237      +15     
+ Misses          459      457       -2     
+ Partials        163      160       -3     
Impacted Files Coverage Δ
...n/java/org/opensearch/knn/common/KNNConstants.java 92.30% <ø> (ø)
.../main/java/org/opensearch/knn/index/KNNScorer.java 69.23% <0.00%> (+4.94%) ⬆️
.../opensearch/knn/index/KNNVectorIndexFieldData.java 100.00% <ø> (ø)
...opensearch/knn/index/KNNVectorScriptDocValues.java 90.47% <ø> (ø)
...rch/knn/index/memory/NativeMemoryEntryContext.java 100.00% <ø> (ø)
...main/java/org/opensearch/knn/jni/FaissService.java 85.71% <ø> (ø)
...c/main/java/org/opensearch/knn/jni/JNIService.java 85.71% <ø> (ø)
...g/opensearch/knn/plugin/script/KNNScoreScript.java 100.00% <ø> (ø)
...arch/knn/plugin/script/KNNScoringScriptEngine.java 66.66% <0.00%> (ø)
...va/org/opensearch/knn/plugin/stats/KNNCounter.java 100.00% <ø> (ø)
... and 74 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c0b1d0...1534b24. Read the comment docs.

Copy link
Member

@martin-gaievski martin-gaievski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thx

@jmazanec15 jmazanec15 requested a review from VijayanB March 29, 2022 00:03
junqiu-lei
junqiu-lei previously approved these changes Mar 29, 2022
VijayanB
VijayanB previously approved these changes Mar 29, 2022
Signed-off-by: John Mazanec <[email protected]>
@jmazanec15 jmazanec15 merged commit 02c30cb into opensearch-project:main Mar 29, 2022
martin-gaievski pushed a commit to martin-gaievski/k-NN that referenced this pull request Mar 30, 2022
Applies spotless to all Java files in project.

Signed-off-by: John Mazanec <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Refactoring Improve the design, structure, and implementation while preserving its functionality v2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants