fix(deployment): typo regarding topologySpreadConstraints #523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpockrandt
requested review from
bbarani,
TheAlgo,
DandyDeveloper,
peterzhuamazon,
prudhvigodithi and
gaiksaya
as code owners
|
Could someone take a look at this PR and review it please? :) |
|
Hi folks, any chance this could be looked at, at the moment the dashboards chart is completely broken. We'd like to update the chart we're using and include TSC's... 😄 |
Looks like there are conflicts in the files. Can you please rebase and resolve the conflicts? |
|
I will update this PR and review. |
Signed-off-by: cpockrandt <[email protected]> Signed-off-by: Peter Zhu <[email protected]>
prudhvigodithi
approved these changes
Jul 24, 2024
gaiksaya
approved these changes
Jul 24, 2024
|
Doesnt seem it requires any backports. |
VILJkid
pushed a commit
to Obmondo/helm-charts-1
that referenced
this pull request
Aug 21, 2024
…-project#523) Signed-off-by: cpockrandt <[email protected]> Signed-off-by: Peter Zhu <[email protected]> Signed-off-by: VILJkid <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There's a bug introduced by a typo in the latest helm chart release.
Issues Resolved
[List any issues this PR will resolve. You should likely open an issue if one does not already exist.]
Check List
For any changes to files within Helm chart directories:
CHANGELOG.mdupdated to reflect changeBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.