Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates the Dockerfile to use non-legacy syntax for environment variables #5417

Merged
merged 1 commit into from
Feb 5, 2025
Merged

Updates the Dockerfile to use non-legacy syntax for environment variables #5417

merged 1 commit into from
Feb 5, 2025

Conversation

dlvenable
Copy link
Member

Description

When building the Docker image I noticed this:

#19 naming to docker.io/library/opensearch-data-prepper:2.11.0-SNAPSHOT done
#19 DONE 0.5s

 1 warning found (use docker --debug to expand):
 - LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format (line 8)

This PR fixes by by using an equals sign (=).

Issues Resolved

None

Check List

  • New functionality includes testing.
  • New functionality has a documentation issue. Please link to it in this PR.
    • New functionality has javadoc added
  • Commits are signed with a real name per the DCO

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@dlvenable dlvenable added the maintenance Issues to help maintain the project, such as improving builds, testing, etc. label Feb 5, 2025
@dlvenable dlvenable merged commit 782793a into opensearch-project:main Feb 5, 2025
48 of 49 checks passed
@dlvenable dlvenable deleted the docker-deprecated-fix branch February 6, 2025 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kkondaka kkondaka kkondaka approved these changes

@sb2k16 sb2k16 Awaiting requested review from sb2k16 sb2k16 is a code owner

@chenqi0805 chenqi0805 Awaiting requested review from chenqi0805 chenqi0805 is a code owner

@engechas engechas Awaiting requested review from engechas engechas is a code owner

@san81 san81 Awaiting requested review from san81 san81 is a code owner

@srikanthjg srikanthjg Awaiting requested review from srikanthjg srikanthjg is a code owner

@graytaylor0 graytaylor0 Awaiting requested review from graytaylor0 graytaylor0 is a code owner

@dinujoh dinujoh Awaiting requested review from dinujoh dinujoh is a code owner

@KarstenSchnitter KarstenSchnitter Awaiting requested review from KarstenSchnitter KarstenSchnitter is a code owner

@oeyh oeyh Awaiting requested review from oeyh oeyh is a code owner

Assignees
No one assigned
Labels
maintenance Issues to help maintain the project, such as improving builds, testing, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dlvenable @kkondaka