Fix flaky render of spans table tests #2263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shenoy Pratik <[email protected]>
Signed-off-by: Shenoy Pratik <[email protected]>
Signed-off-by: Shenoy Pratik <[email protected]>
Signed-off-by: Shenoy Pratik <[email protected]>
Signed-off-by: Shenoy Pratik <[email protected]>
Signed-off-by: Shenoy Pratik <[email protected]>
ps48
changed the title
ps48
changed the title
joshuali925
approved these changes
Nov 27, 2024
TackAdam
approved these changes
Nov 27, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Nov 27, 2024
* Fix flaky load of spans table Signed-off-by: Shenoy Pratik <[email protected]> * update snapshots Signed-off-by: Shenoy Pratik <[email protected]> * update service dep table title Signed-off-by: Shenoy Pratik <[email protected]> * update the data subj to table instead of title Signed-off-by: Shenoy Pratik <[email protected]> * wait for service deps to load Signed-off-by: Shenoy Pratik <[email protected]> * update density test Signed-off-by: Shenoy Pratik <[email protected]> --------- Signed-off-by: Shenoy Pratik <[email protected]> (cherry picked from commit a1dfaea) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
paulstn
pushed a commit
that referenced
this pull request
Nov 27, 2024
* Fix flaky load of spans table * update snapshots * update service dep table title * update the data subj to table instead of title * wait for service deps to load * update density test --------- (cherry picked from commit a1dfaea) Signed-off-by: Shenoy Pratik <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix flaky load of spans table. The CI was acting flaky for load spans table component in the service. The issue was there an incorrect DSL query being sent out to OS to load spans before the DSL state gets updated. The led to the table showing either of the two responses from
incorrect DSL with not filtersor thecorrect DSL the time and service filter.Issues Resolved
#1886
Example of CI being flaky: https://github.com/opensearch-project/dashboards-observability/actions/runs/11902220162/job/33170003645
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.