[Integrations] Add default refresh interval for all the integrations and correct the version on main
#1717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RyanL1997
added
enhancement
RyanL1997
commented
Apr 18, 2024
| @@ -9,7 +9,8 @@ SELECT | |||
| 'apache.access' AS `event.domain` | |||
| FROM {table_name} | |||
| WITH ( | |||
| auto_refresh = 'true', | |||
| auto_refresh = true, | |||
There was a problem hiding this comment.
I also correct the boolean format (cc: @Swiddis)
RyanL1997
commented
Apr 18, 2024
| @@ -23,7 +23,8 @@ CREATE MATERIALIZED VIEW {table_name}__mview AS | |||
| FROM | |||
| {table_name} | |||
| WITH ( | |||
| auto_refresh = 'true', | |||
| auto_refresh = true, | |||
There was a problem hiding this comment.
I also correct the boolean format (cc: @YANG-DB)
YANG-DB
approved these changes
Apr 18, 2024
RyanL1997
force-pushed
the
integration-refresh-interval
branch
from
9b592be to
eeefbfd
Compare
RyanL1997
requested review from
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
rupal-bq,
mengweieric,
vamsimanohar,
Swiddis,
penghuo,
seankao-az,
anirudha,
paulstn and
sumukhswamy
as code owners
Signed-off-by: Ryan Liang <[email protected]>
RyanL1997
force-pushed
the
integration-refresh-interval
branch
from
eeefbfd to
185a4d8
Compare
ps48
approved these changes
Apr 18, 2024
Signed-off-by: Ryan Liang <[email protected]>
RyanL1997
changed the title
main
|
The backport to To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/dashboards-observability/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/dashboards-observability/backport-2.x
# Create a new branch
git switch --create backport/backport-1717-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 000c71bfd221d38e0d83e524b8a0cf1387de4af2
# Push it to GitHub
git push --set-upstream origin backport/backport-1717-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/dashboards-observability/backport-2.xThen, create a pull request where the |
6 tasks
RyanL1997
added a commit
to RyanL1997/dashboards-observability
that referenced
this pull request
Apr 18, 2024
…and correct the version on `main` (opensearch-project#1717) * Add default refresh interval for all the integrations Signed-off-by: Ryan Liang <[email protected]> * Change the version back to 3.0 Signed-off-by: Ryan Liang <[email protected]> --------- Signed-off-by: Ryan Liang <[email protected]>
6 tasks
YANG-DB
pushed a commit
that referenced
this pull request
Apr 18, 2024
…and correct the version on `main` (#1717) (#1724) * Add default refresh interval for all the integrations * Change the version back to 3.0 --------- Signed-off-by: Ryan Liang <[email protected]>
amsiglan
pushed a commit
to amsiglan/dashboards-observability
that referenced
this pull request
Jun 7, 2024
…and correct the version on `main` (opensearch-project#1717) (opensearch-project#1724) * Add default refresh interval for all the integrations * Change the version back to 3.0 --------- Signed-off-by: Ryan Liang <[email protected]> (cherry picked from commit 2cbc016)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
15 Minuteas default.mainNote
For VPC integration still awaiting on PR: #1691 (cc: @YANG-DB )
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.