Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo with VPC filters #1638

Closed
wants to merge 3 commits into from
Closed

Conversation

Swiddis
Copy link
Collaborator

@Swiddis Swiddis commented Mar 27, 2024

Description

Fixes opensearch-project/opensearch-catalog#143

Issues Resolved

Closes opensearch-project/opensearch-catalog#143

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Simeon Widdis <[email protected]>
Copy link

codecov bot commented Mar 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.68%. Comparing base (c14c3f8) to head (84930a0).
Report is 1 commits behind head on main.

❗ Current head 84930a0 differs from pull request most recent head 29483fa. Consider uploading reports for the commit 29483fa to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1638      +/-   ##
==========================================
+ Coverage   57.60%   57.68%   +0.07%     
==========================================
  Files         367      367              
  Lines       13921    13899      -22     
  Branches     3651     3644       -7     
==========================================
- Hits         8019     8017       -2     
+ Misses       5839     5819      -20     
  Partials       63       63              
Flag Coverage Δ
dashboards-observability 57.68% <ø> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Swiddis
Copy link
Collaborator Author

Swiddis commented Apr 15, 2024

Resolved in #1691

@Swiddis Swiddis closed this Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x integrations Used to denote items related to the Integrations project maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Spelling: Protocal => Protocol on the VPC Flow Logs 1.0 Filters
3 participants