Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide the assistant entry when there isn't data2summary agent #417

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

Qxisylolo
Copy link
Contributor

@Qxisylolo Qxisylolo commented Jan 27, 2025

Description

This pr hides the assistant entry when there isn't data2summary agent
!! This pr is a hard dependency that should be merged after opensearch-project/OpenSearch-Dashboards#9277 has been merged.

has agent:
截屏2025-01-27 13 45 13
no agent:
截屏2025-01-27 13 44 44

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test.
  • New functionality has user manual doc added.
  • Commits are signed per the DCO using --signoff.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

codecov bot commented Feb 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.03%. Comparing base (581a7ca) to head (b2b3469).
Report is 20 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #417      +/-   ##
==========================================
- Coverage   87.46%   85.03%   -2.44%     
==========================================
  Files          65       72       +7     
  Lines        1891     2105     +214     
  Branches      473      518      +45     
==========================================
+ Hits         1654     1790     +136     
- Misses        236      313      +77     
- Partials        1        2       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@Hailong-am Hailong-am left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would like to have some unit test

@Qxisylolo Qxisylolo force-pushed the fix/hide_summary_entry branch from 4b00fdd to c9f4960 Compare February 20, 2025 02:49
@Qxisylolo Qxisylolo force-pushed the fix/hide_summary_entry branch from c9f4960 to 771fd18 Compare February 20, 2025 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants