-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
return 404 instead of 500 for missing agent config name #384
Merged
ruanyl
merged 2 commits into
opensearch-project:main
from
ruanyl:fix-missing-agent-500-error
Jan 6, 2025
Merged
return 404 instead of 500 for missing agent config name #384
ruanyl
merged 2 commits into
opensearch-project:main
from
ruanyl:fix-missing-agent-500-error
Jan 6, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yulong Ruan <[email protected]>
Hailong-am
approved these changes
Dec 27, 2024
Signed-off-by: Yulong Ruan <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #384 +/- ##
==========================================
- Coverage 87.46% 84.96% -2.51%
==========================================
Files 65 72 +7
Lines 1891 2068 +177
Branches 473 502 +29
==========================================
+ Hits 1654 1757 +103
- Misses 236 310 +74
Partials 1 1 ☔ View full report in Codecov by Sentry. |
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 6, 2025
* return 404 instead of 500 for missing agent config name Signed-off-by: Yulong Ruan <[email protected]> * add CHANGELOG Signed-off-by: Yulong Ruan <[email protected]> --------- Signed-off-by: Yulong Ruan <[email protected]> (cherry picked from commit ca13184) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
raintygao
pushed a commit
to raintygao/dashboards-assistant
that referenced
this pull request
Jan 22, 2025
…roject#384) * return 404 instead of 500 for missing agent config name Signed-off-by: Yulong Ruan <[email protected]> * add CHANGELOG Signed-off-by: Yulong Ruan <[email protected]> --------- Signed-off-by: Yulong Ruan <[email protected]>
SuZhou-Joe
pushed a commit
that referenced
this pull request
Jan 24, 2025
* return 404 instead of 500 for missing agent config name Signed-off-by: Yulong Ruan <[email protected]> * add CHANGELOG Signed-off-by: Yulong Ruan <[email protected]> --------- Signed-off-by: Yulong Ruan <[email protected]> (cherry picked from commit ca13184) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.