Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature/extensions] Add Action for Get detector API call #721

Merged

Conversation

mloufra
Copy link

@mloufra mloufra commented Nov 11, 2022

Signed-off-by: Frank Lou [email protected]

Description

Create an action implementing ExtensionRestHandler with routes for the get detector API calls.

Issues Resolved

Fixes opensearch-project/opensearch-sdk-java#213

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@mloufra mloufra requested a review from owaiskazi19 November 11, 2022 21:18
Copy link
Member

@dbwiddis dbwiddis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good so far, will need to run spotless on it.

You'll also need to add this action to the list of Rest Handlers in the AnomalyDetectorExtension class.

@dbwiddis dbwiddis changed the title Add Action for Get detector API call [Feature/extensions] Add Action for Get detector API call Nov 12, 2022
@mloufra mloufra marked this pull request as ready for review November 15, 2022 17:06
@mloufra mloufra requested a review from a team November 15, 2022 17:06
@dbwiddis
Copy link
Member

LGTM!

@owaiskazi19
Copy link
Member

@dbwiddis should we wait for your PR to be merged with the new design and make the changes in this PR after that?

Copy link
Member

@owaiskazi19 owaiskazi19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll take care of the changes in my PR!

@owaiskazi19 owaiskazi19 merged commit bcd5a3e into opensearch-project:feature/extensions Nov 15, 2022
@mloufra mloufra deleted the get-detector branch November 15, 2022 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants