[Release 3.0] Added alpha1 qualifier. Updated shadow plugin reference. #1786
+347
−103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -3,7 +3,6 @@ | |||
| * SPDX-License-Identifier: Apache-2.0 | |||
| */ | |||
|
|
|||
| import com.github.jengelman.gradle.plugins.shadow.ShadowPlugin | |||
There was a problem hiding this comment.
In my check on JS plugin, gradleup did not remove this com.github.jengelman.gradle.plugins.shadow.ShadowPlugin, just the namespace of the plugin on gradle mirror is changed.
I just update the apply section and it still pass the assemble.
There was a problem hiding this comment.
Ah thanks for that context! I'll try that.
|
Looking forward to this getting merged soon :) index-management depends on alerting plugin, and the alpha-1 version update (issue #1373) cannot be done in ism until it is completed in alerting plugin. |
66 tasks
|
Hi @AWSHurneyt are we able to fix and merge this PR to unblock others? Thanks! |
…low is re-enabled (opensearch-project#1778) * Force create last run context in monitor worflow metadata when workflow is re-enabled Signed-off-by: Nishtha Mehrotra <[email protected]> * Force creation of re-enabled doc level monitors Signed-off-by: Nishtha Mehrotra <[email protected]> * Updated IT Signed-off-by: Nishtha Mehrotra <[email protected]> --------- Signed-off-by: Nishtha Mehrotra <[email protected]> Co-authored-by: Nishtha Mehrotra <[email protected]> Signed-off-by: AWSHurneyt <[email protected]>
Signed-off-by: AWSHurneyt <[email protected]>
Signed-off-by: AWSHurneyt <[email protected]>
Signed-off-by: AWSHurneyt <[email protected]>
Signed-off-by: AWSHurneyt <[email protected]>
Signed-off-by: AWSHurneyt <[email protected]>
Signed-off-by: AWSHurneyt <[email protected]>
AWSHurneyt
force-pushed
the
3.0-alpha1
branch
from
925ac44 to
cba77be
Compare
Signed-off-by: AWSHurneyt <[email protected]>
Signed-off-by: AWSHurneyt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To align with common utils - opensearch-project/common-utils#775
Related Issues
opensearch-project/opensearch-build#5267
opensearch-project/opensearch-build#3747
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.