Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to run SegRep integ tests using remote store settings #7361

Merged

Conversation

sachinpkale
Copy link
Member

@sachinpkale sachinpkale commented May 2, 2023

Description

  • We want to test various scenarios involving replica promotion, peer recovery, index close and re-open with remote store.
  • These scenarios are already being tested in various integ tests of Segment Replication.
  • In this change, we re-use the same tests by enabling remote store settings.

Related Issues

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions
Copy link
Contributor

github-actions bot commented May 2, 2023

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented May 2, 2023

Gradle Check (Jenkins) Run Completed with:

@sachinpkale
Copy link
Member Author

Checking build failure.

@sachinpkale
Copy link
Member Author

Build is failing due to flaky test mentioned here: #7327

@sachinpkale sachinpkale force-pushed the remote-store-integ-segrep branch from 86c4fbd to cd5e4b2 Compare May 3, 2023 07:14
@github-actions
Copy link
Contributor

github-actions bot commented May 3, 2023

Gradle Check (Jenkins) Run Completed with:

Copy link
Member

@ashking94 ashking94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comments, lgtm otherwise.

Sachin Kale added 3 commits May 5, 2023 10:22
@sachinpkale sachinpkale force-pushed the remote-store-integ-segrep branch from cd5e4b2 to 9a95d4b Compare May 5, 2023 04:52
@github-actions
Copy link
Contributor

github-actions bot commented May 5, 2023

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.remotestore.SegmentReplicationRemoteStoreIT.testScrollWithOngoingSegmentReplication
      1 org.opensearch.indices.replication.SegmentReplicationIT.testScrollCreatedOnReplica

Copy link
Member

@ashking94 ashking94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@codecov-commenter
Copy link

Codecov Report

Merging #7361 (9a95d4b) into main (63fbd0b) will decrease coverage by 0.02%.
The diff coverage is 70.83%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff              @@
##               main    #7361      +/-   ##
============================================
- Coverage     70.54%   70.52%   -0.02%     
+ Complexity    59679    59646      -33     
============================================
  Files          4886     4886              
  Lines        286513   286521       +8     
  Branches      41295    41297       +2     
============================================
- Hits         202112   202081      -31     
- Misses        67771    67818      +47     
+ Partials      16630    16622       -8     
Impacted Files Coverage Δ
...java/org/opensearch/index/shard/StoreRecovery.java 66.87% <33.33%> (+1.72%) ⬆️
...in/java/org/opensearch/index/shard/IndexShard.java 70.00% <71.42%> (-0.04%) ⬇️
...rg/opensearch/index/translog/RemoteFsTranslog.java 74.69% <83.33%> (+0.32%) ⬆️
...anslog/RemoteBlobStoreInternalTranslogFactory.java 76.92% <100.00%> (+1.92%) ⬆️

... and 481 files with indirect coverage changes

@gbbafna gbbafna merged commit 9bf99b4 into opensearch-project:main May 5, 2023
@gbbafna gbbafna added the backport 2.x Backport to 2.x branch label May 5, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request May 5, 2023
)

Signed-off-by: Sachin Kale <[email protected]>
(cherry picked from commit 9bf99b4)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
sachinpkale added a commit to sachinpkale/OpenSearch that referenced this pull request May 5, 2023
sachinpkale added a commit to sachinpkale/OpenSearch that referenced this pull request May 15, 2023
ashking94 pushed a commit to ashking94/OpenSearch that referenced this pull request May 23, 2023
gbbafna pushed a commit that referenced this pull request May 23, 2023
…re settings & Mute flaky test (#7692)

* Add support to run SegRep integ tests using remote store settings (#7361)

Signed-off-by: Sachin Kale <[email protected]>
Signed-off-by: Ashish Singh <[email protected]>

* Mute SegmentReplicationRemoteStoreIT (#7654)

Signed-off-by: Sachin Kale <[email protected]>
Signed-off-by: Ashish Singh <[email protected]>

---------

Signed-off-by: Sachin Kale <[email protected]>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants