-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support to run SegRep integ tests using remote store settings #7361
Add support to run SegRep integ tests using remote store settings #7361
Conversation
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Checking build failure. |
Build is failing due to flaky test mentioned here: #7327 |
86c4fbd
to
cd5e4b2
Compare
Gradle Check (Jenkins) Run Completed with:
|
...src/internalClusterTest/java/org/opensearch/remotestore/SegmentReplicationRemoteStoreIT.java
Show resolved
Hide resolved
server/src/main/java/org/opensearch/index/shard/IndexShard.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor comments, lgtm otherwise.
Signed-off-by: Sachin Kale <[email protected]>
Signed-off-by: Sachin Kale <[email protected]>
Signed-off-by: Sachin Kale <[email protected]>
cd5e4b2
to
9a95d4b
Compare
Gradle Check (Jenkins) Run Completed with:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #7361 +/- ##
============================================
- Coverage 70.54% 70.52% -0.02%
+ Complexity 59679 59646 -33
============================================
Files 4886 4886
Lines 286513 286521 +8
Branches 41295 41297 +2
============================================
- Hits 202112 202081 -31
- Misses 67771 67818 +47
+ Partials 16630 16622 -8
|
) Signed-off-by: Sachin Kale <[email protected]> (cherry picked from commit 9bf99b4) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…ensearch-project#7361) Signed-off-by: Sachin Kale <[email protected]>
…ensearch-project#7361) Signed-off-by: Sachin Kale <[email protected]>
…ensearch-project#7361) Signed-off-by: Sachin Kale <[email protected]> Signed-off-by: Ashish Singh <[email protected]>
…re settings & Mute flaky test (#7692) * Add support to run SegRep integ tests using remote store settings (#7361) Signed-off-by: Sachin Kale <[email protected]> Signed-off-by: Ashish Singh <[email protected]> * Mute SegmentReplicationRemoteStoreIT (#7654) Signed-off-by: Sachin Kale <[email protected]> Signed-off-by: Ashish Singh <[email protected]> --------- Signed-off-by: Sachin Kale <[email protected]>
…ensearch-project#7361) Signed-off-by: Sachin Kale <[email protected]> Signed-off-by: Shivansh Arora <[email protected]>
Description
Related Issues
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.