-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Extensions] Add support for minimum compatible version for extensions with OpenSearch #6003
[Extensions] Add support for minimum compatible version for extensions with OpenSearch #6003
Conversation
Signed-off-by: Sarat Vemulapalli <[email protected]>
Signed-off-by: Sarat Vemulapalli <[email protected]>
Signed-off-by: Sarat Vemulapalli <[email protected]>
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Signed-off-by: Sarat Vemulapalli <[email protected]>
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #6003 +/- ##
============================================
- Coverage 70.75% 70.67% -0.09%
+ Complexity 58721 58689 -32
============================================
Files 4774 4774
Lines 280903 280876 -27
Branches 40582 40582
============================================
- Hits 198760 198513 -247
- Misses 65831 66058 +227
+ Partials 16312 16305 -7
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
server/src/main/java/org/opensearch/extensions/ExtensionsManager.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/extensions/ExtensionsManager.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Sarat Vemulapalli <[email protected]>
Signed-off-by: Sarat Vemulapalli <[email protected]>
Signed-off-by: Sarat Vemulapalli <[email protected]>
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
server/src/main/java/org/opensearch/extensions/ExtensionsManager.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/extensions/ExtensionsSettings.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Sarat Vemulapalli <[email protected]>
Signed-off-by: Sarat Vemulapalli <[email protected]>
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Signed-off-by: Sarat Vemulapalli <[email protected]>
Gradle Check (Jenkins) Run Completed with:
|
Signed-off-by: Sarat Vemulapalli <[email protected]>
Signed-off-by: Sarat Vemulapalli <[email protected]>
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-6003-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 6176ddc0ae831095a0e2e8a38b0f475158abef3b
# Push it to GitHub
git push --set-upstream origin backport/backport-6003-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.x Then, create a pull request where the |
…s with OpenSearch (opensearch-project#6003) * Refactoring extensions config to have real useable values Signed-off-by: Sarat Vemulapalli <[email protected]> * Removing werror Signed-off-by: Sarat Vemulapalli <[email protected]> * Removing extensions feature flag from gradle run Signed-off-by: Sarat Vemulapalli <[email protected]> * Removing description Signed-off-by: Sarat Vemulapalli <[email protected]> * Adding MinimumCompatible Version for extensions Signed-off-by: Sarat Vemulapalli <[email protected]> * Adding changelog Signed-off-by: Sarat Vemulapalli <[email protected]> * Updating changelog Signed-off-by: Sarat Vemulapalli <[email protected]> * Addressing comments Signed-off-by: Sarat Vemulapalli <[email protected]> * Addressing comments Signed-off-by: Sarat Vemulapalli <[email protected]> * Removing debug lines Signed-off-by: Sarat Vemulapalli <[email protected]> * Removing another log line Signed-off-by: Sarat Vemulapalli <[email protected]> * Updating spotless Signed-off-by: Sarat Vemulapalli <[email protected]> --------- Signed-off-by: Sarat Vemulapalli <[email protected]>
…ons with OpenSearch (#6133) * [Extensions] Add support for minimum compatible version for extensions with OpenSearch (#6003) * Refactoring extensions config to have real useable values Signed-off-by: Sarat Vemulapalli <[email protected]> * Removing werror Signed-off-by: Sarat Vemulapalli <[email protected]> * Removing extensions feature flag from gradle run Signed-off-by: Sarat Vemulapalli <[email protected]> * Removing description Signed-off-by: Sarat Vemulapalli <[email protected]> * Adding MinimumCompatible Version for extensions Signed-off-by: Sarat Vemulapalli <[email protected]> * Adding changelog Signed-off-by: Sarat Vemulapalli <[email protected]> * Updating changelog Signed-off-by: Sarat Vemulapalli <[email protected]> * Addressing comments Signed-off-by: Sarat Vemulapalli <[email protected]> * Addressing comments Signed-off-by: Sarat Vemulapalli <[email protected]> * Removing debug lines Signed-off-by: Sarat Vemulapalli <[email protected]> * Removing another log line Signed-off-by: Sarat Vemulapalli <[email protected]> * Updating spotless Signed-off-by: Sarat Vemulapalli <[email protected]> --------- Signed-off-by: Sarat Vemulapalli <[email protected]> * Fixing tests in 2.x Signed-off-by: Sarat Vemulapalli <[email protected]> --------- Signed-off-by: Sarat Vemulapalli <[email protected]>
Is this backwards? Why should the server care about the minimum version of a client? I think the extension should be required to provide a declaration for version compatibility and the server should check it. |
Signed-off-by: Sarat Vemulapalli [email protected]
Description
Part of opensearch-project/opensearch-sdk-java#346.
Added support to define minimum compatible version for extensions talking to OpenSearch.
As we are limiting to minor version compatibility for now, we will revisit this validation when major version compatibility is in the works.
Also, cleaning up unnecessary config needed for extensions as most of it is inherited from plugins back in the day.
Issues Resolved
Closes opensearch-project/opensearch-sdk-java#65
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.