Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.4] Fix 1.x compatibility bug with stored Tasks (#5412) #5440

Merged

Conversation

andrross
Copy link
Member

@andrross andrross commented Dec 3, 2022

When the new 'cancelled' field was introduced it was a miss not to increment the version number on the mapping definitions for the .tasks index. This commit fixes that oversight, as well as modifies the existing backward compatiblity test to ensure that it will catch future mistakes like this one.

Signed-off-by: Andrew Ross [email protected]
(cherry picked from commit 4616dfa)

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@andrross andrross marked this pull request as ready for review December 3, 2022 00:49
@andrross andrross requested review from a team and reta as code owners December 3, 2022 00:49
@github-actions
Copy link
Contributor

github-actions bot commented Dec 3, 2022

Gradle Check (Jenkins) Run Completed with:

When the new 'cancelled' field was introduced it was a miss not to
increment the version number on the mapping definitions for the .tasks
index. This commit fixes that oversight, as well as modifies the
existing backward compatiblity test to ensure that it will catch future
mistakes like this one.

Closes opensearch-project#5376

Signed-off-by: Andrew Ross <[email protected]>
(cherry picked from commit 4616dfa)
Signed-off-by: Andrew Ross <[email protected]>
@andrross andrross force-pushed the backport/backport-5412-to-2.4 branch from 8dfd0ff to 284dcde Compare December 3, 2022 01:10
@github-actions
Copy link
Contributor

github-actions bot commented Dec 3, 2022

Gradle Check (Jenkins) Run Completed with:

@andrross andrross merged commit f2f809e into opensearch-project:2.4 Dec 3, 2022
@andrross andrross deleted the backport/backport-5412-to-2.4 branch December 16, 2022 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants