Bump reactor-netty-http to 1.0.24 in repository-azure (#4880)

[VachaShah]

• Bump reactor-netty-http to 1.0.24

Signed-off-by: Ryan Bogan [email protected]

• Add CHANGELOG entry

Signed-off-by: Ryan Bogan [email protected]

• Bump reactor-netty-core to 1.0.24 to fix failing tests

Signed-off-by: Ryan Bogan [email protected]

• Update SHAs

Signed-off-by: Ryan Bogan [email protected]

• Addressed PR Comments

Signed-off-by: Ryan Bogan [email protected]

Signed-off-by: Ryan Bogan [email protected]

Description

[Describe what this change achieves]

Issues Resolved

[List any issues this PR will resolve]

Check List

• New functionality includes testing.
  • All tests pass
• New functionality has been documented.
  • New functionality has javadoc added
• Commits are signed per the DCO using --signoff
• Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/5562/
• CommitID: 223fbd1

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/5565/
• CommitID: b71ec2b

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/5601/
• CommitID: 0a74580

[VachaShah]

Tests failing for AzureBlobContainerRetriesTests

Suite: Test class org.opensearch.repositories.azure.AzureBlobContainerRetriesTests
  1> [2022-10-25T14:20:08,541][INFO ][o.o.r.a.AzureBlobContainerRetriesTests] [testReadNonexistentBlobThrowsNoSuchFileException] before test
  2> SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".
  2> SLF4J: Defaulting to no-operation (NOP) logger implementation
  2> SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details.
  1> [2022-10-25T14:20:11,919][INFO ][o.o.r.a.AzureBlobContainerRetriesTests] [testReadNonexistentBlobThrowsNoSuchFileException] after test
  2> REPRODUCE WITH: ./gradlew ':plugins:repository-azure:test' --tests "org.opensearch.repositories.azure.AzureBlobContainerRetriesTests.testReadNonexistentBlobThrowsNoSuchFileException" -Dtests.seed=707FEB6EE95D9795 -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=de-DE -Dtests.timezone=Etc/GMT+6 -Druntime.java=11
  2> junit.framework.AssertionFailedError: Unexpected exception type, expected NoSuchFileException but got reactor.core.Exceptions$ReactiveException: java.util.concurrent.TimeoutException: Did not observe any item or terminal signal within 1000ms in 'source(MonoDefer)' (and no fallback has been configured)
        at __randomizedtesting.SeedInfo.seed([707FEB6EE95D9795:5E1D59C3BC07FAF3]:0)
        at org.apache.lucene.util.LuceneTestCase.expectThrows(LuceneTestCase.java:2761)
        at org.apache.lucene.util.LuceneTestCase.expectThrows(LuceneTestCase.java:2749)
        at org.opensearch.repositories.azure.AzureBlobContainerRetriesTests.testReadNonexistentBlobThrowsNoSuchFileException(AzureBlobContainerRetriesTests.java:197)

        Caused by:
        reactor.core.Exceptions$ReactiveException: java.util.concurrent.TimeoutException: Did not observe any item or terminal signal within 1000ms in 'source(MonoDefer)' (and no fallback has been configured)
            at reactor.core.Exceptions.propagate(Exceptions.java:392)
            at reactor.core.publisher.BlockingSingleSubscriber.blockingGet(BlockingSingleSubscriber.java:97)
            at reactor.core.publisher.Mono.block(Mono.java:1707)
            at com.azure.storage.common.implementation.StorageImplUtils.blockWithOptionalTimeout(StorageImplUtils.java:177)
            at com.azure.storage.blob.specialized.BlobClientBase.getPropertiesWithResponse(BlobClientBase.java:1217)
            at com.azure.storage.blob.specialized.BlobClientBase.openInputStream(BlobClientBase.java:321)
            at com.azure.storage.blob.specialized.BlobClientBase.openInputStream(BlobClientBase.java:306)
            at org.opensearch.repositories.azure.AzureBlobStore.lambda$getInputStream$8(AzureBlobStore.java:286)
            at java.base/java.security.AccessController.doPrivileged(Native Method)
            at org.opensearch.repositories.azure.SocketAccess.doPrivilegedException(SocketAccess.java:70)
            at org.opensearch.repositories.azure.AzureBlobStore.getInputStream(AzureBlobStore.java:282)
            at org.opensearch.repositories.azure.AzureBlobContainer.openInputStream(AzureBlobContainer.java:104)
            at org.opensearch.repositories.azure.AzureBlobContainer.readBlob(AzureBlobContainer.java:122)
            at org.opensearch.repositories.azure.AzureBlobContainerRetriesTests.lambda$testReadNonexistentBlobThrowsNoSuchFileException$0(AzureBlobContainerRetriesTests.java:203)
            at org.apache.lucene.util.LuceneTestCase._expectThrows(LuceneTestCase.java:2879)
            at org.apache.lucene.util.LuceneTestCase.expectThrows(LuceneTestCase.java:2754)
            ... 2 more

            Caused by:
            java.util.concurrent.TimeoutException: Did not observe any item or terminal signal within 1000ms in 'source(MonoDefer)' (and no fallback has been configured)
                at reactor.core.publisher.FluxTimeout$TimeoutMainSubscriber.handleTimeout(FluxTimeout.java:295)
                at reactor.core.publisher.FluxTimeout$TimeoutMainSubscriber.doTimeout(FluxTimeout.java:280)
                at reactor.core.publisher.FluxTimeout$TimeoutTimeoutSubscriber.onNext(FluxTimeout.java:419)
                at reactor.core.publisher.FluxOnErrorResume$ResumeSubscriber.onNext(FluxOnErrorResume.java:79)
                at reactor.core.publisher.MonoDelay$MonoDelayRunnable.propagateDelay(MonoDelay.java:271)
                at reactor.core.publisher.MonoDelay$MonoDelayRunnable.run(MonoDelay.java:286)
                at reactor.core.scheduler.SchedulerTask.call(SchedulerTask.java:68)
                at reactor.core.scheduler.SchedulerTask.call(SchedulerTask.java:28)
                at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
                at java.base/java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:304)
                at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
                at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
                at java.base/java.lang.Thread.run(Thread.java:829)
  2> NOTE: leaving temporary files on disk at: /home/ubuntu/OpenSearch/plugins/repository-azure/build/testrun/test/temp/org.opensearch.repositories.azure.AzureBlobContainerRetriesTests_707FEB6EE95D9795-004
  2> Oct 25, 2022 8:20:11 PM com.carrotsearch.randomizedtesting.ThreadLeakControl checkThreadLeaks
  2> WARNING: Will linger awaiting termination of 1 leaked thread(s).
  2> NOTE: test params are: codec=Lucene87, sim=Asserting(RandomSimilarity(queryNorm=false): {}), locale=de-DE, timezone=Etc/GMT+6
  2> NOTE: Linux 5.11.0-1028-aws amd64/Eclipse Adoptium 11.0.13 (64-bit)/cpus=48,threads=1,free=479479488,total=536870912
  2> NOTE: All tests run in this JVM: [AzureBlobContainerRetriesTests]

[VachaShah]

Needs reactor-core bumped to 3.4.23 similar to main

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/5608/
• CommitID: 0a74580

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: SUCCESS ✅
• URL: https://build.ci.opensearch.org/job/gradle-check/5609/
• CommitID: 7a19898

[codecov-commenter]

Codecov Report

Merging #4920 (7a19898) into 1.x (2a2a785) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                1.x    #4920      +/-   ##
============================================
- Coverage     77.86%   77.85%   -0.02%     
+ Complexity    63428    63426       -2     
============================================
  Files          4453     4453              
  Lines        275011   275011              
  Branches      41172    41172              
============================================
- Hits         214145   214112      -33     
+ Misses        43979    43955      -24     
- Partials      16887    16944      +57     

Impacted Files	Coverage Δ
...regations/pipeline/SimulatedAnealingMinimizer.java	0.00% <0.00%> (-93.11%)	⬇️
...pensearch/common/LegacyTimeBasedUUIDGenerator.java	13.63% <0.00%> (-63.64%)	⬇️
...h/index/engine/EngineCreationFailureException.java	50.00% <0.00%> (-50.00%)	⬇️
...n/indices/upgrade/post/UpgradeSettingsRequest.java	30.00% <0.00%> (-45.00%)	⬇️
...rch/client/transport/NoNodeAvailableException.java	57.14% <0.00%> (-42.86%)	⬇️
...pensearch/transport/NodeDisconnectedException.java	60.00% <0.00%> (-40.00%)	⬇️
...nsearch/search/dfs/DfsPhaseExecutionException.java	33.33% <0.00%> (-33.34%)	⬇️
...x/snapshots/IndexShardSnapshotFailedException.java	33.33% <0.00%> (-33.34%)	⬇️
...dices/template/put/PutComponentTemplateAction.java	34.14% <0.00%> (-29.27%)	⬇️
.../java/org/opensearch/index/merge/OnGoingMerge.java	71.42% <0.00%> (-28.58%)	⬇️
... and 463 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.