Apply reproducible builds to plugins #4746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gradle Check (Jenkins) Run Completed with:
|
|
Can we have a rudimentary test for this, please? You also need an entry in CHANGELOG. |
As per gradle [docs] add support to remove timestamps and package with same order which is required from [reproducible] builds This is a result of the discussion in opensearch-project/opensearch-plugin-template-java#38 to apply for all plugins going forward. [docs]: https://docs.gradle.org/current/userguide/working_with_files.html#sec:reproducible_archives [reproducible]: https://reproducible-builds.org/ Signed-off-by: Leonidas Spyropoulos <[email protected]>
inglor
force-pushed
the
reproducible-builds
branch
from
ced83fd to
20f3dfa
Compare
Added a basic test and included the change in Changelog :) |
Gradle Check (Jenkins) Run Completed with:
|
dblock
approved these changes
Oct 14, 2022
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## main #4746 +/- ##
============================================
+ Coverage 70.69% 70.75% +0.05%
+ Complexity 57732 57724 -8
============================================
Files 4687 4687
Lines 277290 277293 +3
Branches 40376 40376
============================================
+ Hits 196042 196186 +144
+ Misses 64947 64718 -229
- Partials 16301 16389 +88
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-4746-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 e44158d4d10d4f8905895ffa50bf9398b8550667
# Push it to GitHub
git push --set-upstream origin backport/backport-4746-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.xThen, create a pull request where the |
ashking94
pushed a commit
to ashking94/OpenSearch
that referenced
this pull request
Nov 7, 2022
As per gradle [docs] add support to remove timestamps and package with same order which is required from [reproducible] builds This is a result of the discussion in opensearch-project/opensearch-plugin-template-java#38 to apply for all plugins going forward. [docs]: https://docs.gradle.org/current/userguide/working_with_files.html#sec:reproducible_archives [reproducible]: https://reproducible-builds.org/ Signed-off-by: Leonidas Spyropoulos <[email protected]> Signed-off-by: Leonidas Spyropoulos <[email protected]> Co-authored-by: Daniel (dB.) Doubrovkine <[email protected]>
inglor
added a commit
to inglor/OpenSearch
that referenced
this pull request
Nov 16, 2022
As per gradle [docs] add support to remove timestamps and package with same order which is required from [reproducible] builds This is a result of the discussion in opensearch-project/opensearch-plugin-template-java#38 to apply for all plugins going forward. [docs]: https://docs.gradle.org/current/userguide/working_with_files.html#sec:reproducible_archives [reproducible]: https://reproducible-builds.org/ Signed-off-by: Leonidas Spyropoulos <[email protected]> Co-authored-by: Daniel (dB.) Doubrovkine <[email protected]> (cherry picked from commit e44158d)
|
I opened the backport manually since the automatic way failed due to changelog.md conflicts. |
reta
pushed a commit
that referenced
this pull request
Nov 16, 2022
As per gradle [docs] add support to remove timestamps and package with same order which is required from [reproducible] builds This is a result of the discussion in opensearch-project/opensearch-plugin-template-java#38 to apply for all plugins going forward. [docs]: https://docs.gradle.org/current/userguide/working_with_files.html#sec:reproducible_archives [reproducible]: https://reproducible-builds.org/ Signed-off-by: Leonidas Spyropoulos <[email protected]> Co-authored-by: Daniel (dB.) Doubrovkine <[email protected]> (cherry picked from commit e44158d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As per gradle docs apply gradle configuration to remove timestamps and package with same order for all plugins. This is required from reproducible builds
Issues Resolved
This PR is a result of opensearch-project/opensearch-plugin-template-java#38 discussion.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.