Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix more failing tests as a result of renaming #457

Merged
merged 3 commits into from
Mar 24, 2021
Merged

Fix more failing tests as a result of renaming #457

merged 3 commits into from
Mar 24, 2021

Conversation

adnapibar
Copy link
Contributor

This commit fixes some more renaming issues and as a result fixes the following failing tests

:qa:logging-config:test 
 - org.opensearch.common.logging.JsonLoggerTests.testPrefixLoggerInJson
 - org.opensearch.common.logging.JsonLoggerTests.testJsonLayout
 - org.opensearch.common.logging.JsonLoggerTests.testJsonInStacktraceMessageIsSplitted
 - org.opensearch.common.logging.JsonLoggerTests.testJsonInMessage
 - org.opensearch.common.logging.JsonLoggerTests.testDeprecatedMessageWithoutXOpaqueId
 - org.opensearch.common.logging.JsonLoggerTests.testStacktrace
 - org.opensearch.common.logging.JsonLoggerTests.testDuplicateLogMessages
 - org.opensearch.common.logging.JsonLoggerTests.testDeprecatedMessage
 - org.opensearch.common.logging.OpenSearchJsonLayoutTests.testLayoutWithAdditionalFields
 - org.opensearch.common.logging.OpenSearchJsonLayoutTests.testLayoutWithAdditionalFieldOverride

:example-plugins:painless-whitelist:yamlRestTest

:modules:reindex:test
 - org.opensearch.index.reindex.remote.RemoteResponseParsersTests.testFailureWithoutIndex
 - org.opensearch.index.reindex.remote.RemoteScrollableHitSourceTests.testParseRejection

Signed-off-by: Rabi Panda [email protected]

@adnapibar adnapibar added >FORK Related to the fork process >test-failure Test failure from CI, local build, etc. Rename Renaming to OpenSearch labels Mar 24, 2021
@odfe-release-bot
Copy link

✅   DCO Check Passed c0bbec7

@odfe-release-bot
Copy link

✅   Gradle Wrapper Validation success c0bbec7

@odfe-release-bot
Copy link

✅   Gradle Precommit success c0bbec7

nknize
nknize approved these changes Mar 24, 2021
View reviewed changes
Copy link
Collaborator

@nknize nknize left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adnapibar adnapibar merged commit 2e3055c into opensearch-project:main Mar 24, 2021
@adnapibar adnapibar deleted the fix-tests branch March 24, 2021 16:33
@adnapibar adnapibar mentioned this pull request Mar 24, 2021
Closed
77 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nknize nknize nknize approved these changes

Assignees
No one assigned
Labels
>FORK Related to the fork process Rename Renaming to OpenSearch >test-failure Test failure from CI, local build, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adnapibar @odfe-release-bot @nknize