[Rename] Fix test SynonymsAnalysisTests.testSynonymsAnalysis for renaming #456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onymsAnalysis for renaming Signed-off-by: Harold Wang <[email protected]>
|
✅ DCO Check Passed 3c49199 |
|
✅ Gradle Wrapper Validation success 3c49199 |
harold-wang
added
:test
adnapibar
reviewed
Mar 24, 2021
| @@ -74,15 +74,15 @@ public void testSynonymsAnalysis() throws IOException { | |||
| IndexSettings idxSettings = IndexSettingsModule.newIndexSettings("index", settings); | |||
| indexAnalyzers = createTestAnalysis(idxSettings, settings, new CommonAnalysisPlugin()).indexAnalyzers; | |||
|
|
|||
| match("synonymAnalyzer", "kimchy is the dude abides", "shay is the elasticsearch man!"); | |||
| match("synonymAnalyzer", "kimchy is the dude abides", "shay is the opensearch man!"); | |||
There was a problem hiding this comment.
We are replacing some of the names used in tests - see #454 which also fixes this failing test.
There was a problem hiding this comment.
Thanks for information, I did not know that you were working on this one:
There was a problem hiding this comment.
I wasn't actually fixing the tests but rather renaming the data and that fixed the test.
There was a problem hiding this comment.
That is also good idea.
|
✅ Gradle Precommit success 3c49199 |
Signed-off-by: Harold Wang <[email protected]>
|
✅ DCO Check Passed 85696aa |
|
✅ Gradle Wrapper Validation success 85696aa |
|
✅ Gradle Precommit success 85696aa |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix failing testcase org.opensearch.analysis.common.SynonymsAnalysisTests.testSynonymsAnalysis
Issue #441
Signed-off-by: Harold Wang [email protected]