[DOCS] Rename some of the asciidoc variables #376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
March 17, 2021 21:05
Signed-off-by: Tianli Feng <[email protected]>
Signed-off-by: Tianli Feng <[email protected]>
Signed-off-by: Tianli Feng <[email protected]>
Signed-off-by: Tianli Feng <[email protected]>
Signed-off-by: Tianli Feng <[email protected]>
Signed-off-by: Tianli Feng <[email protected]>
Signed-off-by: Tianli Feng <[email protected]>
Signed-off-by: Tianli Feng <[email protected]>
Signed-off-by: Tianli Feng <[email protected]>
tlfeng
added
documentation
|
✅ DCO Check Passed |
Signed-off-by: Tianli Feng <[email protected]>
|
✅ DCO Check Passed |
Signed-off-by: Tianli Feng <[email protected]>
|
✅ DCO Check Passed |
added 3 commits
March 18, 2021 17:37
Signed-off-by: Tianli Feng <[email protected]>
Signed-off-by: Tianli Feng <[email protected]>
Signed-off-by: Tianli Feng <[email protected]>
|
✅ DCO Check Passed |
Signed-off-by: Tianli Feng <[email protected]>
|
✅ DCO Check Passed |
Signed-off-by: Tianli Feng <[email protected]>
|
✅ DCO Check Passed |
Signed-off-by: Tianli Feng <[email protected]>
|
✅ DCO Check Passed |
|
❌ DCO Check Failed |
Signed-off-by: Tianli Feng <[email protected]>
|
✅ DCO Check Passed |
Signed-off-by: Tianli Feng <[email protected]>
|
✅ DCO Check Passed |
setiah
reviewed
Mar 19, 2021
| @@ -133,10 +133,10 @@ and add it as a dependency. As an example, we will use the `slf4j-simple` logger | |||
| </dependency> | |||
| -------------------------------------------------- | |||
|
|
|||
| :client-tests: {search-root}/server/src/internalClusterTest/java/org/opensearch/client/documentation | |||
| :hlrc-tests: {search-root}/client/rest-high-level/src/test/java/org/opensearch/client | |||
| :client-tests: {OpenSearch-root}/server/src/internalClusterTest/java/org/opensearch/client/documentation | |||
There was a problem hiding this comment.
{search-root} was originally {elasticsearch-root}, and will be changed to {OpenSearch-root}, which marks the repository name.
Shouldn't this be opensearch-root as per the naming convention?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#238
Description of changes:
The PR continues the work in PR #279
The PR requests merging the code into
oss-docsbranch.Note: The definition of the "reference attributes"
{ ... }needs to be changed accordingly in the build tool to be able to build the docs.reference attributes :
{elasticsearchand{esdefinition of the attributes:
elasticsearchand:escross reference:
<<elasticsearch,elasticsearch>>,<<es,es>>,<<painless-api-reference-...-org-elasticsearch-id:
id="painless-api-reference-...-org-elasticsearch-{search-root}was originally{elasticsearch-root}, and will be changed to{OpenSearch-root}, which marks the repository name.Exception:
{es}and{es-repo-dir}are replaced in PR [DOCS] Replace all {es} with {opensearch} #384 and [DOCS] Replace all {es-repo-dir} with {opensearch-repo-dir} #383.{es-pull}in release notes are not changed.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.