[Rename] o.e.common.util #337
Conversation
|
✅ DCO Check Passed |
nknize
force-pushed
the
rename/server/common/util
branch
from
dd41f90 to
192c23e
Compare
|
✅ DCO Check Passed |
nknize
force-pushed
the
rename/server/common/util
branch
from
192c23e to
d7c1f11
Compare
|
✅ DCO Check Passed |
nknize
force-pushed
the
rename/server/common/util
branch
from
d7c1f11 to
af579b9
Compare
|
✅ DCO Check Passed |
| import org.elasticsearch.common.util.concurrent.EsThreadPoolExecutor; | ||
| import org.elasticsearch.common.util.concurrent.ThreadContext; | ||
| import org.elasticsearch.common.util.concurrent.XRejectedExecutionHandler; | ||
| import org.opensearch.common.util.concurrent.EsRejectedExecutionException; |
There was a problem hiding this comment.
Shouldn't this have changed to OpenSearchRejectedExecutionException as part of #305 (which is for server/src/main/java/org/opensearch/common)?
There was a problem hiding this comment.
see comment below. it was changed in name only, the class was never actually refactored.
| @@ -32,14 +32,14 @@ | |||
| import org.opensearch.common.unit.SizeValue; | |||
| import org.elasticsearch.common.unit.TimeValue; | |||
| import org.elasticsearch.common.util.concurrent.EsExecutors; | |||
| import org.elasticsearch.common.util.concurrent.OpenSearchRejectedExecutionException; | |||
There was a problem hiding this comment.
This was initially changed as part of #285. I'm tryin to gather which PR will be changing this to the rightful state
import org.opensearch.common.util.concurrent.OpenSearchRejectedExecutionException;
There was a problem hiding this comment.
@harold-wang changed the import in name only. The class has not yet been refactored to this new name, that's why it appears in two different forms.
There was a problem hiding this comment.
😂 Really an interesting phenomenon. Thanks to Rabi that told me a ideal way to rename utilizing the refactoring in Intellij in PR # 319, I got the good idea. I realized we have done a few unprofessional work in the early days.
There was a problem hiding this comment.
no worries @harold-wang ! we'll catch it in cleanup phase
nknize
force-pushed
the
rename/server/common/util
branch
from
af579b9 to
f96c195
Compare
|
✅ DCO Check Passed |
This commit refactors the o.e.common.util package to the o.opensearch.common.util namespace. All references throughout the codebase have been refactored. Signed-off-by: Nicholas Walter Knize <[email protected]>
Signed-off-by: Nicholas Walter Knize <[email protected]>
nknize
force-pushed
the
rename/server/common/util
branch
from
f96c195 to
2c5dd20
Compare
|
✅ DCO Check Passed |
server/src/main/java/org/opensearch/rest/RestHeaderDefinition.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Nicholas Walter Knize <[email protected]>
|
✅ DCO Check Passed |
This commit refactors the o.e.common.util package to the o.opensearch.common.util namespace. All references throughout the codebase have been refactored. Signed-off-by: Nicholas Walter Knize <[email protected]>
This commit refactors the o.e.common.util package to the o.opensearch.common.util namespace. All references throughout the codebase have been refactored. Signed-off-by: Nicholas Walter Knize <[email protected]>
This commit refactors the o.e.common.util package to the
o.opensearch.common.util namespace. All references throughout the codebase have
been refactored.
relates #160