Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 1.x] Install plugin command help (#2193) #2264

Merged
merged 1 commit into from
Mar 7, 2022
Merged

[Backport 1.x] Install plugin command help (#2193) #2264

merged 1 commit into from
Mar 7, 2022

Conversation

joshpalis
Copy link
Member

  • edited opensearch-plugin install help output to include plugin URL

Signed-off-by: Joshua Palis [email protected]

  • fixed unit test for plugin install help output by correctly identifying the beginning og the non-option argument list

Signed-off-by: Joshua Palis [email protected]

  • added comments to install plugins help non option argument ouput unit test

Signed-off-by: Joshua Palis [email protected]

  • fixed format violation

Signed-off-by: Joshua Palis [email protected]

  • added additional details on valid plugin ids and how to use plugin URLs

Signed-off-by: Joshua Palis [email protected]

  • added additional information to plugin install help output

Signed-off-by: Joshua Palis [email protected]

Co-authored-by: Joshua Palis [email protected]
(cherry picked from commit b251d2b)
Signed-off-by: Joshua Palis [email protected]

Description

Resolve DCO check failure

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@joshpalis
Install plugin command help (#2193)
cd48f4a 
* edited opensearch-plugin install help output to include plugin URL

Signed-off-by: Joshua Palis <[email protected]>

* fixed unit test for plugin install help output by correctly identifying the beginning og the non-option argument list

Signed-off-by: Joshua Palis <[email protected]>

* added comments to install plugins help non option argument ouput unit test

Signed-off-by: Joshua Palis <[email protected]>

* fixed format violation

Signed-off-by: Joshua Palis <[email protected]>

* added additional details on valid plugin ids and how to use plugin URLs

Signed-off-by: Joshua Palis <[email protected]>

* added additional information to plugin install help output

Signed-off-by: Joshua Palis <[email protected]>

Co-authored-by: Joshua Palis <[email protected]>
(cherry picked from commit b251d2b)
Signed-off-by: Joshua Palis <[email protected]>
@opensearch-ci-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@joshpalis joshpalis mentioned this pull request Feb 25, 2022
Closed
@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure cd48f4a
Log 2828

Reports 2828

@owaiskazi19
Copy link
Member

start gradle check

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure cd48f4a
Log 2830

Reports 2830

@owaiskazi19
Copy link
Member

owaiskazi19 commented Feb 26, 2022 •
edited
Loading

#1957

REPRODUCE WITH: ./gradlew ':server:test' --tests "org.opensearch.cluster.routing.MovePrimaryFirstTests.testClusterGreenAfterPartialRelocation" -Dtests.seed=E5E56A2056FC16C8 -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=sq-AL -Dtests.timezone=America/Cuiaba -Druntime.java=17

org.opensearch.cluster.routing.MovePrimaryFirstTests > testClusterGreenAfterPartialRelocation FAILED
    java.lang.AssertionError: timed out waiting for green state
        at __randomizedtesting.SeedInfo.seed([E5E56A2056FC16C8:B62F0E457DB869DC]:0)
        at org.junit.Assert.fail(Assert.java:89)
        at org.opensearch.test.OpenSearchIntegTestCase.ensureColor(OpenSearchIntegTestCase.java:1019)
        at org.opensearch.test.OpenSearchIntegTestCase.ensureGreen(OpenSearchIntegTestCase.java:958)
        at org.opensearch.test.OpenSearchIntegTestCase.ensureGreen(OpenSearchIntegTestCase.java:947)
        at org.opensearch.cluster.routing.MovePrimaryFirstTests.testClusterGreenAfterPartialRelocation(MovePrimaryFirstTests.java:71)

@owaiskazi19
Copy link
Member

start gradle check

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure cd48f4a
Log 2834

Reports 2834

@saratvemulapalli
Copy link
Member

start gradle check

@saratvemulapalli saratvemulapalli added v1.3.0 backport PRs or issues specific to backporting features or enhancments documentation Improvements or additions to documentation Plugins labels Feb 28, 2022
@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure cd48f4a
Log 2868

Reports 2868

@saratvemulapalli
Copy link
Member

❌   Gradle Check failure cd48f4a Log 2868

Reports 2868

Tests with failures:
 - org.opensearch.cluster.routing.MovePrimaryFirstTests.testClusterGreenAfterPartialRelocation

@owaiskazi19
Copy link
Member

We have a backport PR open for the above test. #2265

@owaiskazi19
Copy link
Member

PR is merged. Let me start the check again.

@owaiskazi19
Copy link
Member

start gradle check

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure cd48f4a
Log 2899

Reports 2899

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure cd48f4a
Log 2901

Reports 2901

@saratvemulapalli
Copy link
Member

start gradle check

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success cd48f4a
Log 3125

Reports 3125

@dblock dblock merged commit 515e997 into opensearch-project:1.x Mar 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@owaiskazi19 owaiskazi19 owaiskazi19 approved these changes

@saratvemulapalli saratvemulapalli saratvemulapalli approved these changes

Assignees
No one assigned
Labels
backport PRs or issues specific to backporting features or enhancments documentation Improvements or additions to documentation Plugins v1.3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@joshpalis @opensearch-ci-bot @owaiskazi19 @saratvemulapalli @dblock