Writable warm replica replication/recovery #17390
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
enhancement
skumawat2025
changed the title
|
❌ Gradle check result for 6fde641: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
gbbafna
reviewed
Feb 19, 2025
server/src/main/java/org/opensearch/index/engine/NRTReplicationEngine.java
Outdated
Show resolved
Hide resolved
gbbafna
reviewed
Feb 20, 2025
| @@ -238,7 +238,8 @@ private IndexMetadata.Builder updateInSyncAllocations( | |||
| allocationId = RecoverySource.ExistingStoreRecoverySource.FORCED_ALLOCATION_ID; | |||
| } else { | |||
| assert (recoverySource instanceof RecoverySource.SnapshotRecoverySource | |||
| || recoverySource instanceof RecoverySource.RemoteStoreRecoverySource) : recoverySource; | |||
| || recoverySource instanceof RecoverySource.RemoteStoreRecoverySource | |||
| || recoverySource instanceof RecoverySource.ExistingStoreRecoverySource) : recoverySource; | |||
There was a problem hiding this comment.
why is this required and what will be the implication ?
Comment on lines
+204
to
+205
| // Return an empty list for warm indices, In this case, replica shards don't require downloading files from remote storage | ||
| // as they can will sync all files from remote in case failure. |
There was a problem hiding this comment.
should we even the replicas checkpoint in case of warm shards ? Also make sure to handle the replication lag metric .
| @@ -190,8 +190,10 @@ public CacheStats stats() { | |||
| public void logCurrentState() { | |||
| int i = 0; | |||
| for (RefCountedCache<K, V> cache : table) { | |||
| logger.trace("SegmentedCache " + i); | |||
| ((LRUCache<K, V>) cache).logCurrentState(); | |||
| if (cache.size() > 0) { | |||
There was a problem hiding this comment.
can we handle size() == 0 case inside logCurrentState ?
| logger.trace("Composite Directory[{}]: Local Directory files - {}", this::toString, () -> Arrays.toString(localFiles)); | ||
| logger.trace("Composite Directory[{}]: Remote Directory files - {}", this::toString, () -> Arrays.toString(remoteFiles)); | ||
| // logger.trace("Composite Directory[{}]: Remote Directory files - {}", this::toString, () -> Arrays.toString(remoteFiles)); | ||
| Set<String> nonBlockLuceneFiles = allFiles.stream() |
There was a problem hiding this comment.
why are we returning just the nonBlockLuceneFiles here ? won't the list be incomplete here as some files can get evicted ?
Signed-off-by: Sandeep Kumawat <[email protected]>
skumawat2025
force-pushed
the
warm-replica-backup
branch
from
6fde641 to
719a67d
Compare
Signed-off-by: Sandeep Kumawat <[email protected]>
skumawat2025
force-pushed
the
warm-replica-backup
branch
from
719a67d to
1963b58
Compare
skumawat2025
commented
Feb 24, 2025
| @@ -190,6 +190,7 @@ public synchronized void updateSegments(final SegmentInfos infos) throws IOExcep | |||
| private void commitSegmentInfos(SegmentInfos infos) throws IOException { | |||
| // get a reference to the previous commit files so they can be decref'd once a new commit is made. | |||
| final Collection<String> previousCommitFiles = getLastCommittedSegmentInfos().files(true); | |||
| logger.info("[{}] commitSegmentInfos() [{}]", shardId, previousCommitFiles); | |||
There was a problem hiding this comment.
Missed it . Will remove this log.
|
❌ Gradle check result for 1963b58: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to implement the Replica Replication and Recovery flow for indices with partial store locality (also known as writable warm indices), which were introduced with the composite directory in PR #12782. It builds upon and addresses comments received on the pending PR #14670.
For writable indices, where primary shards now consist of both localDirectory and remoteDirectory, we've implemented file uploads to remote storage and maintain an LRU fileCache on the node instead of storing all files locally.
We've made several changes to the replication and recovery processes:
Related Issues
Resolves #13647
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.