Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Pull-based Ingestion] Fix snappy related Kafka errors and relax thread leak checks #17240

Merged

Conversation

varunbharadwaj
Copy link
Contributor

Description

This PR is a follow up for pull-based-ingestion to fix the following:

  1. Snappy library errors from Kafka poller.
  2. Flaky test failures in IngestFromKafkaIT by relaxing thread leak checks and closing Kafka test container.

Related Issues

Resolves #17215

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

github-actions bot commented Feb 3, 2025

❌ Gradle check result for 3d45a2a: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Feb 4, 2025

❌ Gradle check result for f988bd8: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@varunbharadwaj varunbharadwaj changed the title [Pull-based Ingestion] Fix snappy related Kafka errors and relax thread leak checks [WIP][Pull-based Ingestion] Fix snappy related Kafka errors and relax thread leak checks Feb 4, 2025
Copy link
Contributor

github-actions bot commented Feb 4, 2025

❌ Gradle check result for 5b8349a: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@varunbharadwaj varunbharadwaj changed the title [WIP][Pull-based Ingestion] Fix snappy related Kafka errors and relax thread leak checks [Pull-based Ingestion] Fix snappy related Kafka errors and relax thread leak checks Feb 5, 2025
Copy link
Contributor

github-actions bot commented Feb 5, 2025

❌ Gradle check result for fd8dbef: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: Varun Bharadwaj <[email protected]>
Copy link
Contributor

github-actions bot commented Feb 5, 2025

❌ Gradle check result for 662fac7: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Feb 5, 2025

✅ Gradle check result for 670e471: SUCCESS

Copy link

codecov bot commented Feb 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.35%. Comparing base (6fb0c1b) to head (0313be2).
Report is 18 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #17240      +/-   ##
============================================
+ Coverage     72.24%   72.35%   +0.10%     
- Complexity    65704    65743      +39     
============================================
  Files          5318     5318              
  Lines        305674   305674              
  Branches      44349    44349              
============================================
+ Hits         220834   221161     +327     
+ Misses        66769    66408     -361     
- Partials      18071    18105      +34     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Feb 5, 2025

✅ Gradle check result for 0313be2: SUCCESS

@andrross andrross merged commit 77e4112 into opensearch-project:main Feb 6, 2025
30 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autocut flaky-test Random test failure that succeeds on second run >test-failure Test failure from CI, local build, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[AUTOCUT] Gradle Check Flaky Test Report for IngestFromKafkaIT
3 participants