[Remote Store] Using RemoteDirectory#delete to clear all segments during migration

[gbbafna]

Description

getRemoteDirectory().deleteStaleSegments will not delete last metadata when pinned timestamps are enabled . Hence we need to use getRemoteDirectory().delete(); which does the clean up comprehensively .

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

• Functionality includes testing. Existing integ tests cover this.
• API changes companion pull request created, if applicable.
• Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[github-actions]

❌ Gradle check result for 86c6e1c: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions]

❌ Gradle check result for c211578: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions]

❕ Gradle check result for c211578: UNSTABLE

• TEST FAILURES:

      1 org.opensearch.cluster.MinimumClusterManagerNodesIT.testThreeNodesNoClusterManagerBlock

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

[codecov]

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 72.31%. Comparing base (302a3fd) to head (c211578).
Report is 8 commits behind head on main.

Files with missing lines	Patch %	Lines
...in/java/org/opensearch/index/shard/IndexShard.java	0.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               main   #17021      +/-   ##
============================================
- Coverage     72.47%   72.31%   -0.16%     
+ Complexity    65618    65478     -140     
============================================
  Files          5291     5291              
  Lines        304347   304330      -17     
  Branches      44182    44181       -1     
============================================
- Hits         220578   220089     -489     
- Misses        65670    66223     +553     
+ Partials      18099    18018      -81     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[opensearch-trigger-bot]

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-17021-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 9de21d1bdf5b7926fcbe6d788c5ec1f4b4fe3ba3
# Push it to GitHub
git push --set-upstream origin backport/backport-17021-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-17021-to-2.x.