Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] pluggable deciders for concurrent search (#15363) #15630

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

Gankris96
Copy link
Contributor

Signed-off-by: Ganesh Ramadurai [email protected]
Signed-off-by: Jay Deng [email protected]
Co-authored-by: Jay Deng [email protected]

(cherry picked from commit 442a928)

Description

Backport of PR #15363

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@jed326 jed326 changed the title [Backport 2.x]pluggable deciders for concurrent search (#15363) [Backport 2.x] pluggable deciders for concurrent search (#15363) Sep 3, 2024
Copy link
Contributor

github-actions bot commented Sep 3, 2024

❌ Gradle check result for 21c6d82: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Sep 3, 2024

❌ Gradle check result for bab8b5e: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: Ganesh Ramadurai <[email protected]>
Signed-off-by: Jay Deng <[email protected]>
Co-authored-by: Jay Deng <[email protected]>

(cherry picked from commit 442a928)
Copy link
Contributor

github-actions bot commented Sep 4, 2024

✅ Gradle check result for e2f0fc6: SUCCESS

Copy link

codecov bot commented Sep 4, 2024

Codecov Report

Attention: Patch coverage is 81.81818% with 22 lines in your changes missing coverage. Please review.

Project coverage is 71.63%. Comparing base (d000171) to head (e2f0fc6).
Report is 1 commits behind head on 2.x.

Files with missing lines Patch % Lines
...va/org/opensearch/search/DefaultSearchContext.java 76.47% 4 Missing and 8 partials ⚠️
...arch/search/deciders/ConcurrentSearchDecision.java 86.95% 2 Missing and 1 partial ⚠️
.../main/java/org/opensearch/index/IndexSettings.java 60.00% 1 Missing and 1 partial ⚠️
...main/java/org/opensearch/search/SearchService.java 66.66% 1 Missing and 1 partial ⚠️
...search/common/settings/AbstractScopedSettings.java 93.33% 0 Missing and 1 partial ⚠️
...earch/search/deciders/ConcurrentSearchDecider.java 0.00% 1 Missing ⚠️
...earch/search/deciders/ConcurrentSearchVisitor.java 87.50% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                2.x   #15630      +/-   ##
============================================
- Coverage     71.78%   71.63%   -0.15%     
+ Complexity    64073    64012      -61     
============================================
  Files          5244     5247       +3     
  Lines        299367   299480     +113     
  Branches      43575    43603      +28     
============================================
- Hits         214886   214528     -358     
- Misses        66497    67015     +518     
+ Partials      17984    17937      -47     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jed326 jed326 merged commit 39aa3e4 into opensearch-project:2.x Sep 4, 2024
38 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 4, 2024
(cherry picked from commit 39aa3e4)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
jed326 pushed a commit that referenced this pull request Sep 4, 2024
(cherry picked from commit 39aa3e4)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants