Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Fix mixed cluster support for OpenSearch 2+ #1191

Merged
merged 6 commits into from
Sep 1, 2021
Merged

[Bug] Fix mixed cluster support for OpenSearch 2+ #1191

merged 6 commits into from
Sep 1, 2021

Conversation

nknize
Copy link
Collaborator

@nknize nknize commented Aug 31, 2021

The version framework only added support for OpenSearch 1.x bwc with legacy
clusters. This commit adds support for v2.0 which will be the last version with
bwc support for legacy clusters (v7.10)

@nknize nknize added bug Something isn't working v2.0.0 Version 2.0.0 backwards-compatibility labels Aug 31, 2021
@opensearch-ci-bot
Copy link
Collaborator

✅   DCO Check Passed f1b43caeb4d31257ad5d4058ec4cb99a5a125707

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Wrapper Validation success f1b43caeb4d31257ad5d4058ec4cb99a5a125707

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Precommit success f1b43caeb4d31257ad5d4058ec4cb99a5a125707

@nknize
Copy link
Collaborator Author

nknize commented Aug 31, 2021

start gradle check

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success f1b43caeb4d31257ad5d4058ec4cb99a5a125707
Log 452

Reports 452

@nknize nknize added the pending backport Identifies an issue or PR that still needs to be backported label Aug 31, 2021
@nknize nknize mentioned this pull request Aug 31, 2021
Merged
@dblock
Copy link
Member

dblock commented Aug 31, 2021 •
edited
Loading

I uderstand that we have tests that will start failing when version is incremented to 2.0 without this, but I am too dumb to know that. Changes in public methods typically should come with changes to unit tests that call those public methods IMO.

@nknize
[Bug] Fix mixed cluster support for OpenSearch 2+
b98b491 
The version framework only added support for OpenSearch 1.x bwc with legacy
clusters. This commit adds support for v2.0 which will be the last version with
bwc support for legacy clusters (v7.10)

Signed-off-by: Nicholas Walter Knize <[email protected]>
@nknize
Copy link
Collaborator Author

nknize commented Sep 1, 2021

start gradle check

1 similar comment
@nknize
Copy link
Collaborator Author

nknize commented Sep 1, 2021

start gradle check

@opensearch-ci-bot
Copy link
Collaborator

✅   DCO Check Passed b98b491

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Wrapper Validation success b98b491

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Precommit success b98b491

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success b98b491
Log 458

Reports 458

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success b98b491
Log 459

Reports 459

@nknize
Copy link
Collaborator Author

nknize commented Sep 1, 2021

start gradle check

@opensearch-ci-bot
Copy link
Collaborator

✅   DCO Check Passed 5c6c265

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Wrapper Validation success 5c6c265

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Precommit success 5c6c265

@nknize
Copy link
Collaborator Author

nknize commented Sep 1, 2021

start gradle check

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Wrapper Validation success 0205aee

@opensearch-ci-bot
Copy link
Collaborator

✅   DCO Check Passed 0205aee

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Precommit failure 0205aee
Log 1043

@nknize
remove unused import
7ab04b7 
Signed-off-by: Nicholas Walter Knize <[email protected]>
@nknize
Copy link
Collaborator Author

nknize commented Sep 1, 2021

start gradle check

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Wrapper Validation success 7ab04b7

@opensearch-ci-bot
Copy link
Collaborator

✅   DCO Check Passed 7ab04b7

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Precommit success 7ab04b7

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success 5c6c265
Log 460

Reports 460

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure 0205aee
Log 461

Reports 461

@nknize
Copy link
Collaborator Author

nknize commented Sep 1, 2021

Changes in public methods typically should come with changes to unit tests that call those public methods IMO.

The changes here need a staged 2.0 branch since they depend on Version.V_2_0_0. This is coming in (#1192). In the meantime, I added wire and compatibility tests that further exercise the logic for bumping versions moving forward.

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure 7ab04b7
Log 462

Reports 462

@nknize
update JoinTaskExecutorTests
0be1dde 
Signed-off-by: Nicholas Walter Knize <[email protected]>
@nknize
Copy link
Collaborator Author

nknize commented Sep 1, 2021

start gradle check

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Precommit success 0be1dde

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Wrapper Validation success 0be1dde

@opensearch-ci-bot
Copy link
Collaborator

✅   DCO Check Passed 0be1dde

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure 0be1dde
Log 464

Reports 464

@nknize
Copy link
Collaborator Author

nknize commented Sep 1, 2021

start gradle check

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Wrapper Validation success e509490

@opensearch-ci-bot
Copy link
Collaborator

✅   DCO Check Passed e509490

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Precommit success e509490

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success e509490
Log 465

Reports 465

@nknize nknize merged commit 3a7f076 into opensearch-project:main Sep 1, 2021
nknize added a commit to nknize/OpenSearch that referenced this pull request Sep 1, 2021
@nknize
[Bug] Fix mixed cluster support for OpenSearch 2+ (opensearch-project…
991d1f6 
…#1191)

The version framework only added support for OpenSearch 1.x bwc with legacy
clusters. This commit adds support for v2.0 which will be the last version with
bwc support for legacy clusters (v7.10)

Signed-off-by: Nicholas Walter Knize <[email protected]>
nknize added a commit that referenced this pull request Sep 1, 2021
@nknize
[Bug] Fix mixed cluster support for OpenSearch 2+ (#1191) (#1195)
b7334f4 
The version framework only added support for OpenSearch 1.x bwc with legacy
clusters. This commit adds support for v2.0 which will be the last version with
bwc support for legacy clusters (v7.10)

Signed-off-by: Nicholas Walter Knize <[email protected]>
nknize added a commit that referenced this pull request Sep 1, 2021
@nknize
[Bug] Fix mixed cluster support for OpenSearch 2+ (#1191) (#1195)
7f524c7 
The version framework only added support for OpenSearch 1.x bwc with legacy
clusters. This commit adds support for v2.0 which will be the last version with
bwc support for legacy clusters (v7.10)

Signed-off-by: Nicholas Walter Knize <[email protected]>
@nknize nknize removed the pending backport Identifies an issue or PR that still needs to be backported label Sep 1, 2021
@saratvemulapalli saratvemulapalli mentioned this pull request Dec 5, 2022
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dblock dblock dblock approved these changes

Assignees
No one assigned
Labels
backwards-compatibility bug Something isn't working v2.0.0 Version 2.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nknize @opensearch-ci-bot @dblock