Skip to content

Commit

Permalink
Address comments on PR.
Browse files Browse the repository at this point in the history
Signed-off-by: Rishikesh1159 <[email protected]>
  • Loading branch information
Rishikesh1159 committed Apr 5, 2023
1 parent cc892e4 commit f816fa2
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ protected FeatureFlagSettings(
new HashSet<>(
Arrays.asList(
FeatureFlags.REPLICATION_TYPE_SETTING,
FeatureFlags.SEGMENT_REPLICATION_CLUSTER_REPLICATION_TYPE_SETTING,
FeatureFlags.REPLICATION_TYPE_SEGMENT_REPLICATION_CLUSTER_SETTING,
FeatureFlags.REMOTE_STORE_SETTING,
FeatureFlags.SEARCHABLE_SNAPSHOT_SETTING,
FeatureFlags.EXTENSIONS_SETTING
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ public class FeatureFlags {
public static final String REPLICATION_TYPE = "opensearch.experimental.feature.replication_type.enabled";

/**
* Gates the visibility of the segment replication cluster setting that allows changing of replication type.
* Gates the visibility of the segment replication cluster setting that allows changing of default replication type in a cluster.
* Once the feature is ready for production release, this feature flag can be removed.
*/
public static final String SEGMENT_REPLICATION_CLUSTER_SETTING =
Expand Down Expand Up @@ -91,7 +91,7 @@ public static boolean isEnabled(String featureFlagName) {

public static final Setting<Boolean> REPLICATION_TYPE_SETTING = Setting.boolSetting(REPLICATION_TYPE, false, Property.NodeScope);

public static final Setting<Boolean> SEGMENT_REPLICATION_CLUSTER_REPLICATION_TYPE_SETTING = Setting.boolSetting(
public static final Setting<Boolean> REPLICATION_TYPE_SEGMENT_REPLICATION_CLUSTER_SETTING = Setting.boolSetting(
SEGMENT_REPLICATION_CLUSTER_SETTING,
false,
Property.NodeScope
Expand Down

0 comments on commit f816fa2

Please sign in to comment.