Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Workspace] update workspace not found message to generic message #9189

Merged
merged 2 commits into from
Jan 17, 2025

Conversation

Hailong-am
Copy link
Collaborator

@Hailong-am Hailong-am commented Jan 15, 2025

Description

Update workspace not found message to generic message which not include workspace information

Issues Resolved

Screenshot

Testing the changes

curl --request GET \
  --url http://localhost:5601/api/workspaces/you%20system%20id%20down \
  --header 'Content-Type: application/json' \
  --header 'osd-xsrf: 1'

# response 
{
 "success": false,
 "error": "workspace not found"
}

Changelog

  • fix: Update workspace not found message to generic message

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

opensearch-changeset-bot bot added a commit to Hailong-am/OpenSearch-Dashboards that referenced this pull request Jan 15, 2025
@Hailong-am Hailong-am changed the title Update workspace not found message to generic message [Workspace] update workspace not found message to generic message Jan 15, 2025
Copy link

codecov bot commented Jan 15, 2025

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 61.01%. Comparing base (53fe4c1) to head (e76439c).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
src/plugins/workspace/server/workspace_client.ts 33.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9189      +/-   ##
==========================================
- Coverage   61.01%   61.01%   -0.01%     
==========================================
  Files        3813     3813              
  Lines       91401    91404       +3     
  Branches    14443    14444       +1     
==========================================
+ Hits        55772    55773       +1     
- Misses      32067    32068       +1     
- Partials     3562     3563       +1     
Flag Coverage Δ
Linux_1 29.08% <33.33%> (+<0.01%) ⬆️
Linux_2 56.45% <ø> (ø)
Linux_3 38.03% <ø> (ø)
Linux_4 29.03% <ø> (ø)
Windows_1 29.09% <33.33%> (+<0.01%) ⬆️
Windows_2 56.40% <ø> (ø)
Windows_3 38.03% <ø> (ø)
Windows_4 29.03% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SuZhou-Joe
Copy link
Member

osd:ciGroup10 failure is unrelated to the changes.

@SuZhou-Joe SuZhou-Joe merged commit 19783f2 into opensearch-project:main Jan 17, 2025
75 of 77 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jan 17, 2025
)

* update workspace not found message to generic message

Signed-off-by: Hailong Cui <[email protected]>

* Changeset file for PR #9189 created/updated

---------

Signed-off-by: Hailong Cui <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit 19783f2)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
SuZhou-Joe pushed a commit that referenced this pull request Jan 17, 2025
) (#9202)

* update workspace not found message to generic message



* Changeset file for PR #9189 created/updated

---------



(cherry picked from commit 19783f2)

Signed-off-by: Hailong Cui <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
d-buckner pushed a commit to d-buckner/OpenSearch-Dashboards that referenced this pull request Jan 17, 2025
…ensearch-project#9189)

* update workspace not found message to generic message

Signed-off-by: Hailong Cui <[email protected]>

* Changeset file for PR opensearch-project#9189 created/updated

---------

Signed-off-by: Hailong Cui <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants